ESD-1640: Read VXC shutdown status from the Shutdown field#525
Open
Phil-Browne wants to merge 4 commits into
Open
ESD-1640: Read VXC shutdown status from the Shutdown field#525Phil-Browne wants to merge 4 commits into
Phil-Browne wants to merge 4 commits into
Conversation
The interactive update prompt showed the current shutdown status from AdminLocked instead of Shutdown, so a VXC that was shut down but not admin-locked displayed as enabled.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #525 +/- ##
==========================================
+ Coverage 79.29% 79.30% +0.01%
==========================================
Files 193 193
Lines 18683 18683
==========================================
+ Hits 14814 14816 +2
+ Misses 2820 2819 -1
+ Partials 1049 1048 -1
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the VXC interactive update prompt to display shutdown status based on the SDK’s Shutdown field (instead of the unrelated AdminLocked field), preventing users from being misled about whether a VXC is currently shut down.
Changes:
- Updated the shutdown status display logic in the interactive update prompt to use
vxc.Shutdown. - Added a regression test covering the “shutdown-but-not-locked” case and the inverse (“locked-but-not-shutdown”).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/commands/vxc/vxc_prompts.go | Reads shutdown status from vxc.Shutdown when displaying the current shutdown state during interactive updates. |
| internal/commands/vxc/vxc_prompts_test.go | Adds a test ensuring the displayed shutdown status reflects Shutdown rather than AdminLocked. |
penzeliz-megaport
previously approved these changes
Jul 13, 2026
penzeliz-megaport
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed for correctness; no findings. LGTM.
…-shutdown-status-field # Conflicts: # internal/commands/vxc/vxc_prompts_test.go
Contributor
Author
|
Merge conflict resolved in b2824f4 |
…-shutdown-status-field
…-shutdown-status-field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The VXC interactive update prompt showed the current shutdown status from
AdminLockedinstead ofShutdown. Those are separate fields on the SDK VXC type, so a VXC that was shut down but not admin-locked displayed as enabled, which could lead someone to toggle shutdown the wrong way.vxc.Shutdowninstead ofvxc.AdminLockedfor the displayed shutdown statusThe write path already used
req.Shutdowncorrectly, so this is a display-only fix.