-
Notifications
You must be signed in to change notification settings - Fork 2
ESD-1584-docs(wasm): document interactive-mode host contract #486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
72e8bc5
docs(wasm): document interactive-mode host contract
Phil-Browne b587315
docs(wasm): address review round 1 (accuracy + tighter tests)
Phil-Browne 562def5
docs(wasm): correct password-masking guidance (review round 2)
Phil-Browne 125e050
fix: address Copilot review feedback on sync guard and tests
Phil-Browne 49db875
fix: address Copilot round 2 review feedback
Phil-Browne 3fc9d13
fix: take promptCallbackMu in the sync-guard test
Phil-Browne 4341bdc
fix: correct ResourceType field comment
Phil-Browne 6d52f53
fix: qualify cancelPrompt docs for confirmation prompts
Phil-Browne efd66b1
fix: remove race and align mock contract in interactive-mode tests
Phil-Browne 39ea407
fix: respond from the callback instead of polling in sync guard test
Phil-Browne 7b236b1
fix: make EndSyncExecution's clamp-to-zero race-free
Phil-Browne 8b75b1b
docs(wasm): fix prompt failure-mode and password type in host contract
Phil-Browne a8f890e
chore: remove hand-edited changelog entry
Phil-Browne f27e6c9
Merge remote-tracking branch 'origin/main' into esd-1584-wasm-interac…
Phil-Browne 7492582
docs(wasm): correct prompt timeout to 10 minutes in host contract docs
Phil-Browne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.