fix: keep heading type on first line when splitting after Shift+Enter - #965
Closed
BetterAndBetterII wants to merge 1 commit into
Closed
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Lexical HeadingNode.insertNewAfter treats any text offset 0 as the start of the heading, so Enter after a linebreak moves the heading onto the latter fragment. Override insertNewAfter for that case so the first half stays a heading and the second becomes a paragraph. Fixes mdx-editor#925
Contributor
|
Thank you for investigating this and for the detailed tests. Since the same behavior reproduces in the official Lexical Playground, the fix belongs in Lexical's HeadingNode.insertNewAfter implementation. I don't want MDXEditor to override HeadingNode.prototype globally as a workaround. Please submit the fix and regression test upstream to Lexical. Once the fix is merged and released there, I will upgrade MDXEditor's Lexical dependencies to include it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HeadingNode.insertNewAftertreats any textoffset === 0as the start of the heading, so Enter after a Shift+Enter linebreak moves the heading onto the latter fragment and downgrades the first line to a paragraph.insertNewAfterinheadingsPluginso a split after a linebreak keeps the first half as a heading, inserts a paragraph for the second half, and drops the leftover break. Start/end Enter behavior is unchanged.Fixes #925
Test plan
npx vitest --run src/test/headings.test.tsx(split after linebreak, Enter at start, Enter at end)npx vitest --run src/test/markdown-shortcut.test.tsx src/test/core.test.tsx