Repository navigation
Correct messages and docs that described things the library does not do - #40
Merged
Merged
Conversation
/register answered "a verification email has been sent" while registration
never emits send_verification_email, so users waited for mail that was not
coming. It now says only what is true, and the docs show how to send one
from the after_register hook.
The refusal raised when auto-linking an unverified email told users to link
the provider "from account settings", an endpoint that does not exist.
The Agent Skill listed eight admin routes the library has never shipped,
claimed admin routes accept require_role("admin") when they require a
superuser, and described an OAuth callback that links through the caller's
session. Agents following it would have built against 404s.
No behaviour changes.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wording and documentation fixes only. No behaviour changes.
/registerno longer claims to have sent a verification email. It answered "a verification email has been sent", but registration never emitssend_verification_email, so users waited for mail that was not coming. It now says "If this email isn't already registered, the account has been created." The docs gain a recipe for sending one from theafter_registerhook.OAuthProviderError; the HTTP response is unchanged.require_role("admin")when they require a superuser, and described an OAuth callback that links through the caller's session.Compatibility
The
/registerresponse text changes. Anything asserting on the old string needs updating; the status code and shape are the same.Checks
ruff, ruff format, mypy --strict, pytest (514 passed, 9 skipped), mkdocs build --strict.