Repository navigation
LINT: Add Biome formatter and linter, prune redundant tests - #10
Merged
Merged
Conversation
…ant tests - Biome, TypeScript and @types/node pinned in devDependencies with a lockfile; CI lints in its own job - Reformat runtime, scripts and tests; drop dead helper params and bracketed env access - Remove duplicate or vacuous fixtures and their goldens; tie hookInterpreter to the shebang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The pack had a typecheck and tests but nothing enforcing style or catching lint-class mistakes, so formatting drifted file to file. This adopts the same Biome setup as mcs-memory, with dev tooling pinned through a lockfile instead of installed ad hoc in CI, and lints everything except recorded goldens by default.
While touching every test file, the suite was audited: fixtures that duplicated another's input and golden, or never reached the path their name claims, are gone. The interpreter check now compares the manifest's hookInterpreter against each hook's shebang directly, so dropping a flag from one side fails.
Stacked on #9.
Test plan
npm ci && npm run lint→ expect no diagnostics--disable-warning=ExperimentalWarningfrom one hookInterpreter in techpack.yaml and runnpm test→ expect the manifest test to fail