Repository navigation
LINT: Add Biome formatter and linter - #46
Merged
bguidolim merged 1 commit intoOct 16, 2026
Merged
Conversation
- Format TS and JSON with Biome (line width 140) and lint with its recommended rules - Replace non-null assertions and a value-returning forEach without changing hook behavior - Run lint as its own CI job alongside the test matrix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The hooks and tests had a typechecker but nothing kept their style consistent, so each change drifted a little. Biome now formats the TypeScript and JSON files and lints them with its recommended rule set, and CI fails on any warning.
Only code and JSON are in scope. Markdown and YAML are left alone because the skills, templates and manifest ship to users, and reformatting them would trigger update notices and could break the byte-identical shared blocks.
The few lint fixes in the hooks keep behavior the same: outside those edits, the code parses to the same syntax tree as before.
Stacked on #45; merge that first.
Test plan
npm ci && npm run lint→ expect no diagnostics!non-null assertion to any hook and runnpm run lint→ expect a failure