Repository navigation
compat.mimalloc: no link names for an ok image; no -latomic - #659
Merged
Merged
Conversation
Co-authored-by: speak-agent <248744407+speak-agent@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compat.mimalloc: an ok image names nothing at its link, and Linux no longer names
-latomic.<arch>-openkal) read thelinuxblock, and its link failed on-lpthreadand-lrt: the image's C library supplies threads and clocks, and an image importskal_*alone. A newopenkalblock names no link flags. The key is written out (ldflags = {}), because a block with no key is read as no block.-latomicis gone from thelinuxblock. Upstream links it only where it finds the library, and mimalloc's atomics are lock-free on every architecture this index builds for. The LLVM toolchain, above a C library of the graph, has no such archive.mimalloc-testspasses locally, and openkal-musl'sexamples/stringsbuilds and runs as an x86_64 ok image with this descriptor.Co-authored-by: speak-agent 248744407+speak-agent@users.noreply.github.com