Fix joker PDF icon and reject natural five of a kind - #71
Merged
Merged
Conversation
The report's inline card cell drew a joker as a bare ★, while the HTML chip renders "★ JOKER". Unify the three joker spellings on one _JOKER_TEXT and widen the Best-5 columns (1.20/1.30 -> 1.60 in) so the wider text does not clip the trailing card. Regenerates both PDF goldens.
Five of a kind is only a valid poker hand with a wild card. Five physical cards of one rank with no joker now score as four of a kind: classify_pattern returns QUADS for a five-identical natural hand, and standings.hand_name names it via the highest-multiplicity rank so it no longer KeyErrors. Simplifies the five-of-a-kind self-test and updates the spec section 5 and requirements R-41/R-44 to the wild-only rule.
The hand-rankings list and the self-test chapter still described natural five of a kind; update both to the wild-only rule and regenerate the bundled HTML.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
★; it now renders★ JOKERto match the HTML chip. The Best-5 card columns are widened (1.20/1.30 → 1.60 in) so the wider text does not clip the trailing card. Both PDF goldens are regenerated.QUADS), andstandings.hand_namenames that shape without crashing. The five-of-a-kind self-test is simplified to the wild-only rule.spec.md§5,requirements.mdR-41/R-44) now state the wild-only five-of-a-kind rule.Notes
Testing
nox -s unit: 6472 passed, 99.85% coverage)nox -s lint typecheck importlint userguide_drift)tools/gen_pdfexport_fixtures.py --check)tools/gen_userguide.py --check)