[WS1][C3] Land forward config-invariance harness and backend provenance - #2
Closed
maxiaosong1124 wants to merge 1 commit into
Closed
Conversation
Add the shared forward accuracy/invariance API, C2 config matrix, backend provenance fail-closed checks, selected-logprob smoke, GPU gate CLI, CPU tests, and closeout evidence for WS1 C3.
Owner
Author
|
Superseded by the upstream PR against RL-Align/RL-Kernel (same head branch). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes RL-Align#269
This PR lands the WS1 C3 shared forward accuracy/invariance harness used by later gates (C8/C10). It provides one API/report schema for batch/chunk/padding/layout config sweeps, C2 logical identity after unpadding, C1-only thresholds, selected-logprob smoke, and fail-closed backend provenance for the independent
cuda_bf16andtriton_cuda_bf16profiles.Parent issue RL-Align#266 remains open. C4–C11 are intentionally out of scope for this PR.
Depends on / stacks with: C1 PR RL-Align#290 and C2 PR RL-Align#292 (this branch is based on
feat/ws1-c2-canonical-workload-268). Merge RL-Align#290 then RL-Align#292 first, or land as a stack.What changed
assert_forward_batch_invariant(...)→ForwardInvarianceReportbuild_config_matrix:BN/full,BN/chunked, B1 singleton full/chunked)restore_logical_order/restore_logical_order_from_paddedforward_invariance,atol=0,rtol=0)forward_accuracytolerances onlyscripts/check_forward_invariance.py:cuda_bf16+ declared CUDAlogpcandidatetriton_cuda_bf16+ declared Tritonbatch_invariant_logpcandidatemissing_requirednodes as redtests/test_forward_invariance.py)rl_engine.kernels.gtestdocs/design/ws1-c3-269-closeout-evidence.mdValidation
The full suite was run with:
Scope boundaries
This PR does not claim completion of:
Those remain tracked by the C4–C11 child issues under RL-Align#266.
This closes only C3. It supplies the report and canonicalization contract that C10 must reuse. It does not invent private thresholds, private logical keys, or alternate report semantics.
Review notes
run_operator_suiteis deferred and out of scope for C3.actual_backendin the C3 CLI is declared from the selected candidate family and validated against the C1 profile contract / C2 expected backend id; full-model dispatch provenance remains owned by C8/C10/C11.fused_logp fallback kernelis the generic CUDA candidate path name, not cross-profile silent fallback.