Skip to content

fix: prevent spinner wrapping in narrow terminals - #41

Merged
maxbeizer merged 4 commits into
mainfrom
fix/spinner-terminal-width
Aug 21, 2026
Merged

maxbeizer merged 4 commits into
mainfrom
fix/spinner-terminal-width

Conversation

@maxbeizer

Copy link
Copy Markdown
Owner

Summary

  • measure the terminal width for every spinner frame so live resizes are respected
  • truncate progress messages by display-cell width with a safety column to prevent automatic wrapping
  • preserve existing behavior when terminal size is unavailable and keep non-terminal output silent

Testing

  • make ci

Fixes #40

maxbeizer and others added 3 commits August 21, 2026 11:26
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@maxbeizer maxbeizer left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the terminal-width spinner changes. The review identified and the branch now addresses MSYS/Cygwin width detection, locale-dependent display widths, and the East Asian ellipsis boundary. Final pass found no remaining high-confidence issues.

@maxbeizer maxbeizer left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the terminal-width spinner changes. The review identified and the branch now addresses MSYS/Cygwin width detection, locale-dependent display widths, and the East Asian ellipsis boundary. Final pass found no remaining high-confidence issues.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@maxbeizer
maxbeizer merged commit 661b28e into main Aug 21, 2026
1 check passed
@maxbeizer
maxbeizer deleted the fix/spinner-terminal-width branch August 21, 2026 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Spinner prints every animation frame when the progress line wraps

1 participant