Skip to content

Onload is missing#63

Open
hdriqi wants to merge 1 commit into
max-mapper:masterfrom
hdriqi:patch-1
Open

Onload is missing#63
hdriqi wants to merge 1 commit into
max-mapper:masterfrom
hdriqi:patch-1

Conversation

@hdriqi

@hdriqi hdriqi commented Jan 11, 2017

Copy link
Copy Markdown

I saw choo handbook and found onload event

I saw choo handbook and found onload event

@yoshuawuyts yoshuawuyts left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops? Don't remember again how we got to this list, but if onunload is on here, onload should be too

@yoshuawuyts

Copy link
Copy Markdown
Collaborator

@shama do you by any chance remember if this was omitted on purpose or not?

@shama

shama commented Jan 12, 2017

Copy link
Copy Markdown
Collaborator

I dont think it was omitted on purpose. Although I don't know if it necessary for either to be in that list. onload and onunload are non-standard callbacks and the on-load library handles copying those as elements update. So also copying those here might be redundant... or I'm missing the use case.

@yoshuawuyts

Copy link
Copy Markdown
Collaborator

@shama nope, don't think you're missing anything - if copying those events is redundant then we should probably also remove unonload? I know that something in on-load isn't quite right still and curious to find out what might be causing it

@ajoslin

ajoslin commented Jan 17, 2017

Copy link
Copy Markdown

What about image load events?

@lukeburns

Copy link
Copy Markdown

is there a reason to use the on-load library instead of this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants