Skip to content

Replace deprecated KeyEvent.character() with string()#106

Open
gnodet wants to merge 1 commit into
mainfrom
fix/deprecated-key-character
Open

Replace deprecated KeyEvent.character() with string()#106
gnodet wants to merge 1 commit into
mainfrom
fix/deprecated-key-character

Conversation

@gnodet
Copy link
Copy Markdown
Contributor

@gnodet gnodet commented May 29, 2026

Summary

  • Upgrade tamboui from 0.2.0 to 0.3.0 to access the new KeyEvent.string() API
  • Replace all deprecated KeyEvent.character() calls with KeyEvent.string() across 6 files: SearchTui, SearchController, SearchInput, ToolPanel, PilotShell, DependenciesTui
  • For char-based comparisons and arithmetic (digit checks, Character.toLowerCase, numeric offsets like key.character() - '1'), use key.string().charAt(0) to preserve identical behavior

Test plan

  • ./mvnw compile -B — zero deprecation warnings for character() in KeyEvent
  • ./mvnw test -B — all tests pass

🤖 Generated with Claude Code

Claude Code on behalf of Guillaume Nodet

Upgrade tamboui to 0.3.0 and migrate all KeyEvent.character() calls
to KeyEvent.string(). Where char-based comparisons or arithmetic are
needed (digit checks, Character.toLowerCase, numeric offsets), use
string().charAt(0) to preserve identical behavior.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@gnodet, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 26 minutes and 38 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 5ceb78f5-e1a6-42c1-8569-3fe2ea8fd0d5

📥 Commits

Reviewing files that changed from the base of the PR and between 720059c and 8b1d587.

📒 Files selected for processing (7)
  • pilot-core/src/main/java/eu/maveniverse/maven/pilot/DependenciesTui.java
  • pilot-core/src/main/java/eu/maveniverse/maven/pilot/PilotShell.java
  • pilot-core/src/main/java/eu/maveniverse/maven/pilot/SearchController.java
  • pilot-core/src/main/java/eu/maveniverse/maven/pilot/SearchInput.java
  • pilot-core/src/main/java/eu/maveniverse/maven/pilot/SearchTui.java
  • pilot-core/src/main/java/eu/maveniverse/maven/pilot/ToolPanel.java
  • pom.xml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/deprecated-key-character

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant