Conversation
|
Warning Review limit reached
More reviews will be available in 40 minutes. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughBumps Maven extension and wrapper versions, updates parent POM and managed dependency versions, refactors CLI jline dependency declarations and shade exclusions, replaces String.format with String.formatted across code and tests, and migrates some Collections usages to List.of with minor input-handling fixes. ChangesBuild Tooling and Code Modernization
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Actionable comments posted: 0 |
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pilot-core/src/main/java/eu/maveniverse/maven/pilot/SearchTui.java`:
- Line 367: SearchTui's change to key.string() means the remaining uses of
KeyEvent.character() must be migrated to key.string() across SearchController,
ToolPanel, SearchInput, PilotShell, and DependenciesTui; replace calls to
key.character() with key.string() and where the code performs char-based
comparisons or arithmetic (e.g., digit checks, Character.toLowerCase, numeric
offsets, switch-on-char) convert the returned string to a char via
string.charAt(0) (or use string.codePointAt(0) for full Unicode codepoint logic)
before applying Character methods or arithmetic; update the referenced
methods/blocks in SearchController (char checks around line ~76), ToolPanel
(~670), SearchInput (~105), PilotShell (around ~293, ~376-378, ~401-409), and
DependenciesTui (~513-514) to use key.string() + .charAt(0) (or codePointAt
where appropriate) so comparisons and digit arithmetic behave identically.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 84b4fb44-3dd0-4c55-8e0d-cfa8a3abd083
📒 Files selected for processing (1)
pilot-core/src/main/java/eu/maveniverse/maven/pilot/SearchTui.java
| } | ||
| if (key.code() == KeyCode.CHAR) { | ||
| searchBuffer.insert(cursorPos, key.character()); | ||
| searchBuffer.insert(cursorPos, key.string()); |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Find all remaining usages of key.character() in the codebase
# Search for key.character() calls
echo "=== Searching for key.character() usages ==="
rg -nP '\bkey\.character\(\)' --type=java -C2
# Also check for KeyEvent variable names with character() calls
echo -e "\n=== Searching for any .character() on KeyEvent-like variables ==="
rg -nP '\b\w+\.character\(\)' --type=java -g '**/*Tui.java' -g '**/*Input.java' -g '**/*Controller.java' -C2Repository: maveniverse/pilot
Length of output: 6943
Complete the KeyEvent.character() → key.string() migration across the codebase
SearchTui.javais updated (lines ~367 and ~428), but remainingkey.character()usages still exist in:SearchController.java(~line 76)ToolPanel.java(~line 670)SearchInput.java(~line 105)PilotShell.java(~lines 293, 376-378, 401-409)DependenciesTui.java(~lines 513-514)
- Those remaining call sites need to switch to
key.string(), with proper conversion where the code currently relies on acharfor comparisons/arithmetic (digits /Character.toLowerCase, etc.).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pilot-core/src/main/java/eu/maveniverse/maven/pilot/SearchTui.java` at line
367, SearchTui's change to key.string() means the remaining uses of
KeyEvent.character() must be migrated to key.string() across SearchController,
ToolPanel, SearchInput, PilotShell, and DependenciesTui; replace calls to
key.character() with key.string() and where the code performs char-based
comparisons or arithmetic (e.g., digit checks, Character.toLowerCase, numeric
offsets, switch-on-char) convert the returned string to a char via
string.charAt(0) (or use string.codePointAt(0) for full Unicode codepoint logic)
before applying Character methods or arithmetic; update the referenced
methods/blocks in SearchController (char checks around line ~76), ToolPanel
(~670), SearchInput (~105), PilotShell (around ~293, ~376-378, ~401-409), and
DependenciesTui (~513-514) to use key.string() + .charAt(0) (or codePointAt
where appropriate) so comparisons and digit arithmetic behave identically.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
2 participants
Changes:
Summary by CodeRabbit
Chores
Refactor
Tests