Open
Conversation
added 3 commits
May 24, 2019 14:50
…o tokens can be accessible in background after first unlock (helps with apple watch notification response when device is locked).
…o tokens can be accessible in background after first unlock (helps with apple watch notification response when device is locked).
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| kSecAttrService as String: kOTPService as NSString, | ||
|
|
||
| // Allow keychain access in the background after first unlock. | ||
| kSecAttrAccessible as String: kSecAttrAccessibleAfterFirstUnlock as NSString |
There was a problem hiding this comment.
Colon Violation: Colons should be next to the identifier when specifying a type and next to the key in dictionary literals. (colon)
| kSecAttrGeneric as String: data as NSData, | ||
| kSecValueData as String: generator.secret as NSData, | ||
| kSecAttrService as String: kOTPService as NSString, | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #208 +/- ##
===========================================
+ Coverage 97.22% 99.34% +2.11%
===========================================
Files 6 6
Lines 397 153 -244
===========================================
- Hits 386 152 -234
+ Misses 11 1 -10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Repository owner
deleted a comment
Jan 13, 2022
Repository owner
deleted a comment
Jan 13, 2022
Repository owner
deleted a comment
Jan 13, 2022
Repository owner
deleted a comment
Jan 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
•Added kSecAttrAccessible:kSecAttrAccessibleAfterFirstUnlock keychain attribute so tokens can be accessible in background after first unlock. This helps with apple watch notification response when device is locked.
•Also made the HMAC func public