Skip to content

Show review comments in PR Conversation tab with reply/resolve#99

Merged
mattmoran56 merged 1 commit into
mainfrom
session/fix/pr-missing-review-comments
May 15, 2026
Merged

Show review comments in PR Conversation tab with reply/resolve#99
mattmoran56 merged 1 commit into
mainfrom
session/fix/pr-missing-review-comments

Conversation

@mattmoran56
Copy link
Copy Markdown
Owner

Summary

  • Review threads (inline code comments) were fetched on PR load but only rendered in the diff view. The Conversation tab now lists them grouped by file path, with line/line-range labels, reply, and resolve/unresolve actions — using the existing InlineThread component for consistency.
  • Empty-state copy now only shows when both issue comments and review threads are empty.
  • Expanded mockPRReviewThreads to include real id + comments so Storybook / FullApp render the new section meaningfully.

Test plan

  • npm test -- tests/unit/components/pullrequests/ tests/unit/stores/prReviewStore.test.ts — 44/44 pass, includes 9 new PRConversationTab tests covering grouping, line-range labels, resolve, unresolve (expand→click), reply (Cmd+Enter), and empty-state visibility.
  • New Storybook stories: PR/PRConversationTabWithReviewThreads, OnlyUnresolved, AllResolved, NoReviewComments.
  • Screenshots needed — this is a UI change so per CLAUDE.md the PR description must include screenshots with absolute raw URLs. I didn't capture them; please add screenshots of the new Conversation-tab section before merging.

🤖 Generated with Claude Code

Inline code review threads were fetched but only rendered in the diff
view. The Conversation tab now lists them grouped by file with reply
and resolve/unresolve actions, so reviewers don't have to open Files
just to see what's outstanding. Adds component tests and stories;
expands mock review threads with real comments.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@mattmoran56 mattmoran56 merged commit 8ec97a9 into main May 15, 2026
3 checks passed
@mattmoran56 mattmoran56 deleted the session/fix/pr-missing-review-comments branch May 15, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant