Fix setup.py to not use pip internal APIs#64
Open
JustAnalyze wants to merge 2 commits intomattloper:masterfrom
Open
Fix setup.py to not use pip internal APIs#64JustAnalyze wants to merge 2 commits intomattloper:masterfrom
JustAnalyze wants to merge 2 commits intomattloper:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The current
setup.pyimports frompip.reqandpip._internal.req, which are internal pip APIs that should not be used. This causesModuleNotFoundError: No module named 'pip'when building in PEP 517 isolated environments (used by modern build tools likeuv,pip>=20,build, etc.).Solution
requirements.txtdirectly using standard Python file I/Odistutilstosetuptools(distutils is deprecated in Python 3.10+)python_requiresfield for better package metadataTesting
Tested with:
pip install .uv pip install .python -m buildAll installation methods work correctly after this fix.
Related Issues
This fixes issues when using modern Python packaging tools that use PEP 517 isolated builds.