Made the elvis operator a macro that checks each step of an expression#12
Open
beef331 wants to merge 6 commits into
Open
Made the elvis operator a macro that checks each step of an expression#12beef331 wants to merge 6 commits into
beef331 wants to merge 6 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes the elvis operator better at handling complex expressions. It also removes the incorrect
try exceptusage that caught defects, as they just hide bugs if you use the 'proper'--panics: on.This solves the underlying problem that @ajusa faced.
If replicated for the
?template it could also resolve #10, #11.