Conversation
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
MTRNord
force-pushed
the
MTRNord/better-inline-code
branch
from
101f32c to
4f35560
Compare
Deploying matrix-website with
|
| Latest commit: |
4f35560
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e59ef381.matrix-website.pages.dev |
| Branch Preview URL: | https://mtrnord-better-inline-code.matrix-website.pages.dev |
awtj8o81ryywg793
left a comment
awtj8o81ryywg793
left a comment
There was a problem hiding this comment.
Personally the red always felt a bit out of place. This is now a bit closer to the big blocks but not sure if thats a good thing.
I'd say it's a good thing. It helps make everything feel more cohesive. Currently, the red styling suggests that something is broken.
| color: $color-code-color; | ||
| border-radius: 0.3rem; | ||
| padding: 1px 5px 2px; | ||
| font-size: 0.8em; |
There was a problem hiding this comment.
| font-size: 0.8em; |
I don't think we need to decrease the size of the text. Keeping it the same size ensures consistency, which I believe is something we should strive for in this situation.
There was a problem hiding this comment.
The reason here is that with all the border and background it always felt larger than the rest. Hence this tried to visually match the surroundings. But maybe thats just me
There was a problem hiding this comment.
Maybe this one is subjective. For me the .8 makes inline code hard(er) to read in text blocks because the font size changes in the flow.
|
Some vertical misalignment on my Android phone: |
| background-color: $color-code-background; | ||
| color: $color-code-color; | ||
| border-radius: 0.3rem; | ||
| padding: 1px 5px 2px; |
There was a problem hiding this comment.
We need to talk about units in general. If you use absolute units for the paddings and relative units for the font size, then people with other base font sizes will have misaligned code blocks.
4 participants
Description
I am not sure if this is actually better or not. Happy to hear feedback on this though.
Personally the red always felt a bit out of place. This is now a bit closer to the big blocks but not sure if thats a good thing.
I also tried to size match the text around it a bit better than before.
Related issues
Role
Website & Content WG.
Timeline
Signoff
See commits