Conversation
Quality of life improvement as this handles 2 columns a bit nicer overall Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
… on twim Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
MTRNord
added
aesthetic
Deploying matrix-website with
|
| Latest commit: |
9718836
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d29b8cfb.matrix-website.pages.dev |
| Branch Preview URL: | https://mtrnord-improve-post-layout.matrix-website.pages.dev |
| color: #777; | ||
| } | ||
|
|
||
| // "//" rotated 90deg sits naturally at top-left |
There was a problem hiding this comment.
Does this mean anything that is going over my head or is it just stylish?
It's now inconsistent with pages such as /blog
There was a problem hiding this comment.
Its just stylish.
I didnt want to use " as it doesnt really feel right for twim.
and I did overlook /blog indeed oops. Good catch.
There was a problem hiding this comment.
The inconsistency on /blog is now fixed.
There was a problem hiding this comment.
are you intentionally not applying this globally?
https://d29b8cfb.matrix-website.pages.dev/foundation/working-groups/website-content/#charter
Signed-off-by: MTRNord <MTRNord@users.noreply.github.com>
| left: 5px; | ||
| top: 40px; | ||
| width: 1px; | ||
| height: 100%; |
There was a problem hiding this comment.
this line at 100% height has the combined lineheight of the text plus 10px top and bottom padding as defined somewhere according to my devtools. you are moving it 10px+30px=40px down, which means it exceeds the blockquote's container.
| height: 100%; | |
| height: calc(100% - 50px); |
would bring that back so the line actually ends with the last line instead of the blockquote element. imo it looks a bit leaner. wdyt?
|
|
||
| // "//" rotated 90deg sits naturally at top-left | ||
| &::before { | ||
| content: "//"; |
There was a problem hiding this comment.
This looks a bit strange imho. Is this a new common pattern? I think that quotes with just the | make the layout look smoother.
3 participants
Description
This does a few things:
flex: 3;. This is minor and not visually really obviousRelated issues
Role
Website & content WG
Timeline
Signoff
In the commits