Conversation
nathangavin
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes a whitelist bypass in matomo-proxy.php.
Previously, a request to the opt-out proxy was accepted if either the file parameter matched $VALID_FILES or module.action matched $SUPPORTED_METHODS. Because proxy.php prioritizes file for JS requests, an attacker could send a valid opt-out module.action together with an arbitrary file value and bypass the file whitelist.
The fix makes file take precedence: when a file parameter is present, it must be explicitly whitelisted. If no file is provided, the request must match one of the supported opt-out module.action pairs. Regression tests were added for both GET and POST variants of the mixed-parameter bypass.
Checklist
Review