Bump to 1.36.1: the chosen filter operator is visible in every theme - #40
Merged
Merged
Conversation
PR #39. The column-filter popup marked the selected comparison by painting a background from a colour name no theme declares, so every theme got the light-theme literal written beside it: 1.22:1 on Dark Modern, 1.31:1 on HC Black, on the one element saying whether Apply will write `contains` or `>=`. All four themes are past 7:1 now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump and changelog for PR #39.
package.jsonline 5 andpackage-lock.jsonlines 3 and 9 only — the two"version"fields, nothing else in the lockfile (npm run check:leakstill reports all 646 resolutions on the public registry).Tagging
v1.36.1on mergedmainbuilds the.vsixonto a GitHub Release. The Marketplace upload stays manual, and this one is worth it: a dark-theme or high-contrast user currently cannot read which comparison the filter popup is about to apply.