Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dark mode now renders authored ink on charcoal paper in iOS and Android while retaining the original stroke colors and light paper in saved documents and exports. A shared linear-lightness filter keeps native ink, text color helpers, and rendered diagram images consistent, including transparency. Older native binaries fall back to light document display.
Stacked on #61. Native GPU preparation precompiles dark compositing away from input handling; this change preserves the existing frame scheduler and serialization contracts.
Validation: 178 Jest tests, TypeScript, package build, release checks, native raster/shader comparisons, CPU/GPU live and committed RGBA comparisons, unchanged authored serialization, example TypeScript and iOS/Android bundle exports pass. CI passes at 8316b8c (run 39657401827), including the independent runner’s strict CPU/GPU color comparison. MathNotes Release build and direct dark paper/text/diagram display pass; switching appearance preserves its authored body byte-for-byte. The image wrapper measures its outer React Native view to avoid Skia 2.2’s onSize null-view race during Fabric mounting. OpenNotes native integration and complete application export verification remain pending. Existing interaction timing gates on #61 still fail; this PR does not claim stall-free behavior.
Simplify and security reviews completed; fixed missing source entries in the package whitelist and sanitized decoder errors so private diagram data URIs cannot appear in errors. Existing large native renderer/container and canvas files are deliberately kept intact: these changes only thread one display flag through their existing lifecycle and compose a filter at their existing output layer. New display logic is in small dedicated helpers; splitting native input/render ownership here would expand concurrency risk.
Keep unmerged pending independent engine review and application verification. No release requested.