Repository navigation
Fix missing images and text in note thumbnails - #42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inserted images and typed text were visible in the editor but absent from library and page-sidebar thumbnails because those thumbnails only used the native ink preview.
Compose thumbnails separately from notebook data, including images and text with the editor’s crop, rotation, position, and stacking order. Refresh legacy covers lazily without rewriting note bodies or changing modification dates. Thumbnail failures do not block note saves, and obsolete sidebar rendering requests are cancelled.
Add an iOS ImageIO fallback for existing HEIC photos that Skia cannot decode. Original image files and ink previews remain unchanged, preserving existing notes and PDF export behavior. No Mobile Ink changes or new dependencies are required.
Validation
npm run typecheckpassed.npm test: 116 tests passed, including rendering, legacy compatibility, save failures, and concurrent thumbnail repair.npm run test:thumbnail-native: six native image checks passed, including HEIC decoding and JPEG orientation.