Skip to content

caja-python-object.c: Remove the extra reference on the PyObject file wrappers when adding them to the python list.#64

Open
mtwebster wants to merge 1 commit intomate-desktop:masterfrom
mtwebster:extra-file-ref
Open

caja-python-object.c: Remove the extra reference on the PyObject file wrappers when adding them to the python list.#64
mtwebster wants to merge 1 commit intomate-desktop:masterfrom
mtwebster:extra-file-ref

Conversation

@mtwebster
Copy link

@mtwebster mtwebster commented Feb 3, 2021

PyObjects start with a refcount of 1. Adding them to a PyList adds
a second - which gets removes during the list's destruction. The
additional ref was keeping its associated CajaFile from ever being
finalized.

Steps to reproduce problem:

  1. Install python-caja and some python MenuProvider extension.
  2. Create a folder with a couple of image files inside. Be sure to
    allow thumbs to generate.
  3. Enter the folder, select one or more files (so menus are
    generated). De-select and leave the folder (but do not close
    caja). If you were to watch for the files' finalize to run,
    you'd notice it does not.
  4. touch or otherwise modify one of the image files from a terminal
  5. Re-enter the folder in caja.
  6. See that loading runs forever, modified file(s) never
    display. Note: even if you only modify one file, it could cause
    all of the files to fail to load, depending on their order during
    enumeration.

When no more views are displaying a file, that file should be finalized.
When it's not it ends up in an undefined state, as it has no monitors
flag it as needing to be updated

@mtwebster
caja-python-object.c: Remove the extra reference on the PyObject
94a2558 
file wrappers when adding them to the python list. PyObjects start
with a refcount of 1. Adding them to a PyList adds a second - which
gets removes during the list's destruction. The additional ref was
keeping its associated CajaFile from ever being finalized.

Steps to reproduce problem:
1) Install python-caja and some python MenuProvider extension.
2) Create a folder with a couple of image files inside. Be sure to
   allow thumbs to generate.
3) Enter the folder, select one or more files (so menus are
   generated). De-select and leave the folder (but do not close
   caja). If you were to watch for the files' finalize to run,
   you'd notice it does not.
4) touch or otherwise modify one of the image files from a terminal
5) Re-enter the folder in caja.
6) See that loading runs forever, modified file(s) never
   display. Note: even if you only modify one file, it could cause
   all of the files to fail to load, depending on their order during
   enumeration.

When no more views are displaying a file, that file should be finalized.
When it's not it ends up in an undefined state, as it has no monitors
flag it as needing to be updated
@raveit65 raveit65 requested a review from a team April 6, 2021 06:02
@lukefromdc
Copy link
Member

lukefromdc commented May 6, 2021

What would be usable extensions for this? I am totally unfamiliar with most of the python extensions (I have just one and don't have problems with image files) but this sounds nasty

@mtwebster
Copy link
Author

mtwebster commented May 14, 2021

caja-rename will trigger this, or folder-color-caja

mtwebster added a commit to mtwebster/caja that referenced this pull request May 16, 2021
@mtwebster
caja-directory.c: Fix memory leak.
19d5d87 
When creating a new file (using a template, for instance), file->
details->is_added could potentially be FALSE, and cause this file to
not be finalized along with other files if the view directory is
destroyed.

This can cause issues when re-entering that directory, with the file
being in an undefined state, and could prevent the view from fully
loading the location (this is identical behavior to that described
in mate-desktop/python-caja#64.

To reproduce:
- Create an svg file and save in ~/Templates.
- Right-click, Create document-> svg file, name it whatever.
- Navigate out of the folder.
- Modify the file in a visible manner.
- Re-enter the folder, note that it never finishes loading.

Ref:
linuxmint/nemo#2736
@mtwebster mtwebster mentioned this pull request May 16, 2021
Merged
lukefromdc pushed a commit to mate-desktop/caja that referenced this pull request May 19, 2021
@mtwebster @lukefromdc
caja-directory.c: Fix memory leak.
6a3dbb0 
When creating a new file (using a template, for instance), file->
details->is_added could potentially be FALSE, and cause this file to
not be finalized along with other files if the view directory is
destroyed.

This can cause issues when re-entering that directory, with the file
being in an undefined state, and could prevent the view from fully
loading the location (this is identical behavior to that described
in mate-desktop/python-caja#64.

To reproduce:
- Create an svg file and save in ~/Templates.
- Right-click, Create document-> svg file, name it whatever.
- Navigate out of the folder.
- Modify the file in a visible manner.
- Re-enter the folder, note that it never finishes loading.

Ref:
linuxmint/nemo#2736
@lukefromdc
Copy link
Member

lukefromdc commented May 19, 2021

Note that mate-desktop/caja#1528 fixed a related problem with thumbnails not loading after video files were rendered to the desktop, a job which takes several minutes. Those files are not readable until they are done, thus delaying thumbnail generation and usually blocking creation of the thumbnail prior to that

raveit65 pushed a commit to mate-desktop/caja that referenced this pull request Jul 21, 2022
@mtwebster
caja-directory.c: Fix memory leak.
fdb1a1d 
When creating a new file (using a template, for instance), file->
details->is_added could potentially be FALSE, and cause this file to
not be finalized along with other files if the view directory is
destroyed.

This can cause issues when re-entering that directory, with the file
being in an undefined state, and could prevent the view from fully
loading the location (this is identical behavior to that described
in mate-desktop/python-caja#64.

To reproduce:
- Create an svg file and save in ~/Templates.
- Right-click, Create document-> svg file, name it whatever.
- Navigate out of the folder.
- Modify the file in a visible manner.
- Re-enter the folder, note that it never finishes loading.

Ref:
linuxmint/nemo#2736
@lukefromdc
Copy link
Member

lukefromdc commented Aug 31, 2023

What is the status of this? I don't have anything installed that could be used to test it and don't know enough about python to evaluate the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mtwebster @lukefromdc