FTCBFS: hard codes the build architecture pkg-config - #97
Open
vkareh wants to merge 1 commit into
Open
Conversation
libmatekbd fails to cross build from source, because it hard codes the build architecture pkg-config in libmatekbd/Makefile.am. As a consequence it silently fails looking up the glib_genmarshal variable in glib-2.0.pc and fails running it. Running pkg-config beyond the configure phase is not recommended precisely, because one ends up with such silent failures that only turn into real failures later. This change moves this invocation into configure.ac where the right pkg-config is known via the PKG_CONFIG variable and where the lookup succeeds in native builds as in cross builds. Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1062792
Member
Author
|
/cc @helmutg This PR is directly from your patch in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1062792 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
libmatekbd fails to cross build from source, because it hard codes the build architecture pkg-config in libmatekbd/Makefile.am. As a consequence it silently fails looking up the glib_genmarshal variable in glib-2.0.pc and fails running it. Running pkg-config beyond the configure phase is not recommended precisely, because one ends up with such silent failures that only turn into real failures later.
This change moves this invocation into configure.ac where the right pkg-config is known via the PKG_CONFIG variable and where the lookup succeeds in native builds as in cross builds.
Fixes https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1062792