matekbd-status: Fix green tint on indicator text - #96
Open
vkareh wants to merge 2 commits into
Open
Conversation
Keyboard layout indicator text could render with subpixel antialiasing even though SUBPIXEL was already avoided, because cairo falls back to the font's own fontconfig antialiasing mode whenever the requested mode is DEFAULT. This produced green/magenta color fringing on light-colored indicator text. Fixes #71
The keyboard layout indicator icon was always drawn at scale 1 and then stretched by GTK+ to fit HiDPI outputs, making it blurrier than the surrounding panel text. This change renders both the flag image and the text-based icon at the monitor's actual device scale so GTK+ can downscale instead of upscale.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keyboard layout indicator text could render with subpixel antialiasing even though SUBPIXEL was already avoided, because cairo falls back to the font's own fontconfig antialiasing mode whenever the requested mode is DEFAULT. This produced green/magenta color fringing on light-colored indicator text.
Also render indicator icon properly on HiDPI displays.
Fixes #71