Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/App.scss
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
@import 'bulma/css/bulma.min.css';

iframe {
display: none;
}
75 changes: 14 additions & 61 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,73 +1,26 @@
import React from 'react';
import React, { useState } from 'react';
import './App.scss';
import { peopleFromServer } from './data/people';
import { Person } from './types/Person';
import Input from './components/Input';

export const App: React.FC = () => {
const { name, born, died } = peopleFromServer[0];
const [selectedPerson, setSelectedPerson] = useState<Person | null>(null);

return (
<div className="container">
<main className="section is-flex is-flex-direction-column">
<h1 className="title" data-cy="title">
{`${name} (${born} - ${died})`}
<h1 className="title" data-cy="title" data-qa="title">
{selectedPerson
? `${selectedPerson.name} (${selectedPerson.born} - ${selectedPerson.died})`
: 'No selected person'}
</h1>

<div className="dropdown is-active">
<div className="dropdown-trigger">
<input
type="text"
placeholder="Enter a part of the name"
className="input"
data-cy="search-input"
/>
</div>

<div className="dropdown-menu" role="menu" data-cy="suggestions-list">
<div className="dropdown-content">
<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Bernard Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Antone Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Petronella de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Hercke</p>
</div>
</div>
</div>
</div>

<div
className="
notification
is-danger
is-light
mt-3
is-align-self-flex-start
"
role="alert"
data-cy="no-suggestions-message"
>
<p className="has-text-danger">No matching suggestions</p>
</div>
<Input
people={peopleFromServer}
delay={300}
onSelected={person => setSelectedPerson(person)}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You compute a trimmed/lowercased version of the query here: const queryLower = query.trim().toLowerCase(); — but you still rely on the raw query in the effect dependencies. As a result the effect will re-run when query changes by whitespace only (e.g. "John" -> "John ") even though the trimmed text didn't change, causing redundant filtering. The task requires: "Don't run filtering again if the text has not changed (a pause in typing happened when the text was the same as before)." Consider deriving queryLower outside and using it in the dependency array or storing the last trimmed value in a ref and skipping filtering when it hasn't changed.

onInputChange={() => setSelectedPerson(null)}
/>
</main>
</div>
);
Expand Down
108 changes: 108 additions & 0 deletions src/components/Input.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,108 @@
import { Person } from '../types/Person';
import { useEffect, useRef, useState } from 'react';
interface Props {
people: Person[];
delay?: number;
onSelected: (person: Person) => void;
onInputChange?: () => void;
}

export default function Input({
people,
delay = 300,
onSelected,
onInputChange,
}: Props) {
const [query, setQuery] = useState('');
const [isOpen, setIsOpen] = useState(false);
const [suggestions, setSuggestions] = useState<Person[]>([]);
const lastTrimmedRef = useRef('');

useEffect(() => {
const trimmed = query.trim().toLowerCase();

if (lastTrimmedRef.current === trimmed) {
return;
}

lastTrimmedRef.current = trimmed;

const timeout = window.setTimeout(() => {
const nextSuggestions =
trimmed === ''
? people
: people.filter(pers => pers.name.toLowerCase().includes(trimmed));

setSuggestions(nextSuggestions);
}, delay);

return () => {
clearTimeout(timeout);
};
}, [query, delay, people]);

const handleSelect = (selectedPerson: Person) => {
setQuery(selectedPerson.name);
setIsOpen(false);
onSelected(selectedPerson);
};

return (
<div className={isOpen ? 'dropdown is-active' : 'dropdown'}>
<div className="dropdown-trigger">
<input
className="input is-medium"
type="text"
placeholder="Enter a part of the name"
value={query}
onChange={e => {
setQuery(e.target.value);
setIsOpen(true);
onInputChange?.();
}}
onFocus={() => {
setIsOpen(true);
if (query.trim() === '') {
setSuggestions(people);
}
}}
data-cy="search-input"
data-qa="search-input"
/>
</div>
<div className="dropdown-menu" id="dropdown-menu" role="menu">
<div
className="dropdown-content"
data-cy="suggestions-list"
data-qa="suggestions-list"
>
{query.trim() !== '' && suggestions.length === 0 ? (
<div
className="dropdown-item"
data-cy="no-suggestions-message"
data-qa="no-suggestions-message"
>
No matching suggestions
</div>
) : (
suggestions.map(pers => (
<button
key={pers.slug}
type="button"
className="dropdown-item"
data-cy="suggestion-item"
data-qa="suggestion-item"
onMouseDown={e => {
e.preventDefault();
handleSelect(pers);
}}
>
{pers.name}
</button>
))
)}
</div>
</div>
</div>
);
}
Loading