Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 16 additions & 60 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,73 +1,29 @@
import React from 'react';
import './App.scss';
import { peopleFromServer } from './data/people';
import { Person } from './types/Person';
import { Autocomplete } from './Autocomplete/Autocomplete';
import { useState } from 'react';

export const App: React.FC = () => {
const { name, born, died } = peopleFromServer[0];
const [selectedPerson, setSelectedPerson] = useState<Person | null>(null);

const handleQueryChange = () => {
setSelectedPerson(null);
};

return (
<div className="container">
<main className="section is-flex is-flex-direction-column">
<h1 className="title" data-cy="title">
{`${name} (${born} - ${died})`}
{selectedPerson
? `${selectedPerson.name} (${selectedPerson.born} - ${selectedPerson.died})`
: 'No selected person'}
</h1>

<div className="dropdown is-active">
<div className="dropdown-trigger">
<input
type="text"
placeholder="Enter a part of the name"
className="input"
data-cy="search-input"
/>
</div>

<div className="dropdown-menu" role="menu" data-cy="suggestions-list">
<div className="dropdown-content">
<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Bernard Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Antone Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Petronella de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Hercke</p>
</div>
</div>
</div>
</div>

<div
className="
notification
is-danger
is-light
mt-3
is-align-self-flex-start
"
role="alert"
data-cy="no-suggestions-message"
>
<p className="has-text-danger">No matching suggestions</p>
</div>
<Autocomplete
people={peopleFromServer}
onSelect={setSelectedPerson}
onQueryChange={handleQueryChange}
/>
</main>
</div>
);
Expand Down
106 changes: 106 additions & 0 deletions src/Autocomplete/Autocomplete.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
import { Person } from '../types/Person';
import React, { useEffect, useRef, useState } from 'react';

type Props = {
people: Person[];
delay?: number;
onSelect: (person: Person) => void;
onQueryChange: () => void;
};

export const Autocomplete: React.FC<Props> = ({
people,
delay = 300,
onSelect,
onQueryChange,
}) => {
const [query, setQuery] = useState('');
const [debouncedQuery, setDebouncedQuery] = useState(query);
const [isOpen, setIsOpen] = useState(false);
const [filteredPeople, setFilteredPeople] = useState<Person[]>([]);

const isSelecting = useRef(false);
const prevQuery = useRef('');
const visiblePeople = query === '' ? people : filteredPeople;

useEffect(() => {
const timer = setTimeout(() => {
setDebouncedQuery(query);
}, delay);

return () => clearTimeout(timer);
}, [query, delay]);

useEffect(() => {
if (prevQuery.current === debouncedQuery) {
return;
}

prevQuery.current = debouncedQuery;
const normalized = debouncedQuery.trim().toLowerCase(); // <-- обрізаємо пробіли

const result =
normalized === '' // якщо після trim пустий рядок, показуємо всіх людей
? people
: people.filter(person =>
person.name.toLowerCase().includes(normalized),

Check failure on line 46 in src/Autocomplete/Autocomplete.tsx

View workflow job for this annotation

GitHub Actions / run_linter (20.x)

Expected indentation of 10 spaces but found 12
);

Check failure on line 47 in src/Autocomplete/Autocomplete.tsx

View workflow job for this annotation

GitHub Actions / run_linter (20.x)

Expected indentation of 8 spaces but found 10

setFilteredPeople(result);
}, [debouncedQuery, people]);

return (
<div className={`dropdown ${isOpen ? 'is-active' : ''}`}>
<div className="dropdown-trigger">
<input
type="text"
placeholder="Enter a part of the name"
className="input"
data-cy="search-input"
value={query}
onChange={event => {
setQuery(event.target.value);
if (!isSelecting.current) {
onQueryChange();
}

isSelecting.current = false;
}}
onFocus={() => setIsOpen(true)}
/>
</div>
{isOpen && (
<div className="dropdown-menu" data-cy="suggestions-list">
<div className="dropdown-content">
{visiblePeople.map(person => (
<div
key={person.name}
className="dropdown-item"
data-cy="suggestion-item"
onClick={() => {
onSelect(person);
setQuery(person.name);
setIsOpen(false);
isSelecting.current = true;
}}
>
<p
className={
person.sex === 'm' ? 'has-text-link' : 'has-text-danger'
}
>
{person.name}
</p>
</div>
))}
{visiblePeople.length === 0 && query !== '' && (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The condition for displaying 'No matching suggestions' currently uses query. This can cause the message to flash briefly while waiting for the debounced search to complete, because visiblePeople is temporarily an empty array.

To prevent this, the condition should be based on a state that reflects that a search has actually been performed, such as debouncedQuery.

<div className="dropdown-item" data-cy="no-suggestions-message">
<p className="has-text-danger">No matching suggestions</p>
</div>
)}
</div>
</div>
)}
</div>
);
};
Loading