Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ that will suggest people matching an entered text.
- Install Prettier Extention and use this [VSCode settings](https://mate-academy.github.io/fe-program/tools/vscode/settings.json) to enable format on save.
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_autocomplete/) and add it to the PR description.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://AngelaStrechen.github.io/react_autocomplete/) and add it to the PR description.
- Don't remove the `data-qa` attributes. It is required for tests.

## Troubleshooting
Expand Down
9 changes: 5 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
"devDependencies": {
"@cypress/react18": "^2.0.1",
"@faker-js/faker": "^8.4.1",
"@mate-academy/scripts": "^1.8.5",
"@mate-academy/scripts": "^2.1.3",
"@mate-academy/students-ts-config": "*",
"@mate-academy/stylelint-config": "*",
"@types/lodash.debounce": "^4.0.9",
Expand Down
71 changes: 12 additions & 59 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,73 +1,26 @@
import React from 'react';
import React, { useState } from 'react';
import './App.scss';
import { peopleFromServer } from './data/people';
import { Person } from './types/Person';
import { Autocomplete } from './components/Autocomplete';

export const App: React.FC = () => {
const { name, born, died } = peopleFromServer[0];
const [selectedPerson, setSelectedPerson] = useState<Person | null>(null);

return (
<div className="container">
<main className="section is-flex is-flex-direction-column">
<h1 className="title" data-cy="title">
{`${name} (${born} - ${died})`}
{selectedPerson
? `${selectedPerson.name} (${selectedPerson.born} - ${selectedPerson.died})`
: 'No selected person'}
</h1>

<div className="dropdown is-active">
<div className="dropdown-trigger">
<input
type="text"
placeholder="Enter a part of the name"
className="input"
data-cy="search-input"
/>
</div>

<div className="dropdown-menu" role="menu" data-cy="suggestions-list">
<div className="dropdown-content">
<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Bernard Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Antone Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Petronella de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Hercke</p>
</div>
</div>
</div>
</div>

<div
className="
notification
is-danger
is-light
mt-3
is-align-self-flex-start
"
role="alert"
data-cy="no-suggestions-message"
>
<p className="has-text-danger">No matching suggestions</p>
</div>
<Autocomplete
people={peopleFromServer}
delay={300}
onSelected={setSelectedPerson}
/>
</main>
</div>
);
Expand Down
127 changes: 127 additions & 0 deletions src/components/Autocomplete.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
import React, { useEffect, useRef, useState } from 'react';
import { Person } from '../types/Person';

type Props = {
people: Person[];
delay?: number;
onSelected: (person: Person | null) => void;
};

export const Autocomplete: React.FC<Props> = ({
people,
delay = 300,
onSelected,
}) => {
const [query, setQuery] = useState('');
const [suggestions, setSuggestions] = useState<Person[]>([]);
const [isDropdownVisible, setIsDropdownVisible] = useState(false);

const prevQuery = useRef('');

useEffect(() => {
const normalizedQuery = query.trim();

if (prevQuery.current === normalizedQuery) {
return;
}

const timer = setTimeout(() => {
prevQuery.current = normalizedQuery;

if (!normalizedQuery) {
setSuggestions(people);

return;
}

const filtered = people.filter(person =>
person.name.toLowerCase().includes(normalizedQuery.toLowerCase()),
);

setSuggestions(filtered);
}, delay);

return () => clearTimeout(timer);
}, [query, delay, people]);

const handleInputChange = (event: React.ChangeEvent<HTMLInputElement>) => {
const value = event.target.value;

setQuery(value);
setIsDropdownVisible(true);

onSelected(null);
};

const handleSelect = (person: Person) => {
setQuery(person.name);
setIsDropdownVisible(false);

onSelected(person);
};

const handleFocus = () => {
setIsDropdownVisible(true);

if (!query.trim()) {
setSuggestions(people);
}
};

return (
<>
<div className={`dropdown ${isDropdownVisible ? 'is-active' : ''}`}>
<div className="dropdown-trigger">
<input
type="text"
className="input"
placeholder="Enter a part of the name"
value={query}
onChange={handleInputChange}
onFocus={handleFocus}
data-cy="search-input"
/>
</div>

{isDropdownVisible && (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This condition renders the dropdown menu container (dropdown-menu) even when there are no suggestions. This results in an empty box being displayed. It would be better to render this container only when there are suggestions to show by changing the condition to isDropdownVisible && suggestions.length > 0.

<div className="dropdown-menu" role="menu" data-cy="suggestions-list">
<div className="dropdown-content">
{suggestions.map(person => (
<div
key={person.slug}
className="dropdown-item"
data-cy="suggestion-item"
onClick={() => handleSelect(person)}
>
<p
className={
person.sex === 'm' ? 'has-text-link' : 'has-text-danger'
}
>
{person.name}
</p>
</div>
))}
</div>
</div>
)}
</div>

{isDropdownVisible && suggestions.length === 0 && (
<div
className="
notification
is-danger
is-light
mt-3
is-align-self-flex-start
"
role="alert"
data-cy="no-suggestions-message"
>
<p className="has-text-danger">No matching suggestions</p>
</div>
)}
</>
);
};