Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ that will suggest people matching an entered text.
- Install Prettier Extention and use this [VSCode settings](https://mate-academy.github.io/fe-program/tools/vscode/settings.json) to enable format on save.
- Implement a solution following the [React task guideline](https://github.com/mate-academy/react_task-guideline#react-tasks-guideline).
- Use the [React TypeScript cheat sheet](https://mate-academy.github.io/fe-program/js/extra/react-typescript).
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://<your_account>.github.io/react_autocomplete/) and add it to the PR description.
- Replace `<your_account>` with your Github username in the [DEMO LINK](https://NazarenkoAnna.github.io/react_autocomplete/) and add it to the PR description.
- Don't remove the `data-qa` attributes. It is required for tests.

## Troubleshooting
Expand Down
72 changes: 12 additions & 60 deletions src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,73 +1,25 @@
import React from 'react';
import React, { useState } from 'react';
import './App.scss';
import { peopleFromServer } from './data/people';
import { Person } from './types/Person';
import { PeopleAutocomplete } from './components/PeopleAutocomplete';

export const App: React.FC = () => {
const { name, born, died } = peopleFromServer[0];
const [selectedPerson, setSelectedPerson] = useState<Person | null>(null);

const handleSelect = (person: Person | null) => {
setSelectedPerson(person);
};

return (
<div className="container">
<main className="section is-flex is-flex-direction-column">
<h1 className="title" data-cy="title">
{`${name} (${born} - ${died})`}
{selectedPerson
? `${selectedPerson.name} (${selectedPerson.born} - ${selectedPerson.died})`
: 'No selected person'}
</h1>

<div className="dropdown is-active">
<div className="dropdown-trigger">
<input
type="text"
placeholder="Enter a part of the name"
className="input"
data-cy="search-input"
/>
</div>

<div className="dropdown-menu" role="menu" data-cy="suggestions-list">
<div className="dropdown-content">
<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Bernard Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter Antone Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Haverbeke</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-link">Pieter de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Petronella de Decker</p>
</div>

<div className="dropdown-item" data-cy="suggestion-item">
<p className="has-text-danger">Elisabeth Hercke</p>
</div>
</div>
</div>
</div>

<div
className="
notification
is-danger
is-light
mt-3
is-align-self-flex-start
"
role="alert"
data-cy="no-suggestions-message"
>
<p className="has-text-danger">No matching suggestions</p>
</div>
<PeopleAutocomplete people={peopleFromServer} onSelect={handleSelect} />
</main>
</div>
);
Expand Down
107 changes: 107 additions & 0 deletions src/components/PeopleAutocomplete.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
import { useEffect, useRef, useState } from 'react';
import { Person } from '../types/Person';

interface Props {
people: Person[];
delay?: number;
onSelect: (person: Person | null) => void;
}

export const PeopleAutocomplete: React.FC<Props> = ({
people,
delay = 300,
onSelect,
}) => {
const [query, setQuery] = useState('');
const [isActive, setIsActive] = useState(false);
const [lastQuery, setLastQuery] = useState('');
const field = useRef<HTMLInputElement>(null);

useEffect(() => {
field.current?.focus();
}, []);

useEffect(() => {
const timerId = window.setTimeout(() => {
const normalizeQuery = query.trim();

if (normalizeQuery !== lastQuery) {
setLastQuery(normalizeQuery);
}
}, delay);

return () => {
clearTimeout(timerId);
};
}, [query, delay]);

Check warning on line 36 in src/components/PeopleAutocomplete.tsx

View workflow job for this annotation

GitHub Actions / run_linter (20.x)

React Hook useEffect has a missing dependency: 'lastQuery'. Either include it or remove the dependency array

const filteredPeople = people.filter(person =>
person.name.toLowerCase().includes(lastQuery.toLowerCase()),
);

return (
<>
<div className={`dropdown ${isActive ? 'is-active' : ''}`}>
<div className="dropdown-trigger">
<input
type="text"
placeholder="Enter a part of the name"
className="input"
data-cy="search-input"
value={query}
ref={field}
onChange={event => {
setQuery(event.target.value);
onSelect(null);
}}
onFocus={() => setIsActive(true)}
onBlur={() => setIsActive(false)}
/>
</div>

{filteredPeople.length !== 0 && (
<div className="dropdown-menu" role="menu" data-cy="suggestions-list">
<div className="dropdown-content">
{filteredPeople.map(person => (
<div
className="dropdown-item"
data-cy="suggestion-item"
key={person.slug}
onMouseDown={() => {
onSelect(person);
setQuery(person.name);
setIsActive(false);
}}
>
<p
className={
person.sex === 'm' ? 'has-text-link' : 'has-text-danger'
}
>
{person.name}
</p>
</div>
))}
</div>
</div>
)}
</div>

{filteredPeople.length === 0 && lastQuery.length !== 0 && isActive && (
<div
className="
notification
is-danger
is-light
mt-3
is-align-self-flex-start
"
role="alert"
data-cy="no-suggestions-message"
>
<p className="has-text-danger">No matching suggestions</p>
</div>
)}
</>
);
};