Skip to content

generate table dom#1792

Open
MaksVash wants to merge 2 commits intomate-academy:masterfrom
MaksVash:master
Open

generate table dom#1792
MaksVash wants to merge 2 commits intomate-academy:masterfrom
MaksVash:master

Conversation

@MaksVash
Copy link
Copy Markdown

@MaksVash MaksVash commented Apr 4, 2026

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great work on the overall structure and the logic for calculating the age and century! However, a change is needed as the automated tests are currently failing. The test log indicates it cannot find the gender value (e.g., 'Male') in the generated table. This means the gender property from each person object is not being correctly rendered into its own table cell (<td>).

Please review the loop where you create the table rows and ensure that you are creating and appending a cell for the gender property for each person. Once that's addressed, your solution should be ready to go!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Excellent work on this submission! I am approving your solution as you've successfully addressed the previous feedback. The gender value is now being correctly handled and displayed in its own table cell. All calculations are correct, the DOM is manipulated properly, and all task requirements have been met. Your solution is complete and works perfectly. Well done!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants