chore: Remove unused pinact configuration - #27
Merged
Merged
Conversation
- SHA pinning is covered by ghalint's action_ref_should_be_full_length_commit_sha - pinact is not run locally either
- The actual tag of ludeeus/action-shellcheck is 2.0.0; v2.0.0 does not exist - Detected by zizmor's ref-version-mismatch audit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Remove
.pinact.yaml, which was added alongside ghalint in #24 but no longer hasa role.
ghalint runenforcesaction_ref_should_be_full_length_commit_sha, so the SHApinning check is already covered. pinact is not run locally either, which leaves
the config with nothing to do.
Changes
.pinact.yamlludeeus/action-shellcheckinci.ymlNote
The actual tag of
ludeeus/action-shellcheckis2.0.0;v2.0.0does notexist. The pinned SHA itself is correct, so only the comment was wrong.
It was found by zizmor's
ref-version-mismatchaudit. Neither ghalint nor CodeQL detects this, soadopting zizmor is worth considering separately.