feat: convert package to pure Dart - #49
Conversation
|
Important Review skippedToo many files! This PR contains 177 files, which is 77 over the limit of 100. To get a review, reduce the PR to 100 files or fewer by splitting it into smaller PRs or changing its base branch. Upgrade to a paid plan to raise the limit. This review couldn't start because sufficient usage credits or metered capacity aren't available. Add credits or update usage-based reviews in the billing tab, then retry. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (177)
You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
cd8a4c4 to
1985fa8
Compare
04d7050 to
cd97ecb
Compare
master-wayne7
left a comment
There was a problem hiding this comment.
Hey @ricardodalarme , this is awesome, thank you! 🎉
Really appreciate the work here: dropping the Flutter dependency and making the word lists tree-shakeable is a great improvement, and the test coverage plus the data cleanup along the way shows real care. Everything checks out on CI.
Great to hear VGV is planning to build on this, very cool to hear as a maintainer. Merging this as v3.0.0 since it's a breaking change (sync API). Thanks again for such a solid contribution! 🙌
Description
Hey @master-wayne7 👋🏻, thanks for this great package!
I noticed the Flutter dependency was only there to load the
.txtword lists, , so I'm proposing this PR to change it to load the words directly from Dart files instead. This lets us drop the async initialization and turn safe_text into a fully pure-Dart projectA nice side effect: the word lists are now tree-shakeable, so you only ship the languages you actually use.
We're planning to use this in a large codebase here at VGV, and a Dart-only, tree-shakeable dependency makes that a lot simpler. I'd appreciate it if you could take a look 🙂