Repository navigation
fix(P1.1): hold flasher COM lease until timed-out OS process exits - #353
Merged
Merged
Conversation
… exits Defer launch and operation timeout results until QProcess confirms termination, including FailedToStart races, rather than treating asynchronous kill() as an exit acknowledgement. Clear worker generation before publishing one terminal result. Exercise a real hung subprocess and clean worker reuse in the native S8 harness.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production safety milestone — P1.1 real process retirement
Root cause:
FirmwareWorkercalledQProcess::kill()and immediately emittedoperationTimedOut/operationLaunchTimedOut, even though kill is asynchronous.FirmwareManagercould then clearbusyand the supervisor could release firmware COM ownership while an external flasher process was still alive. This race risks overlapping serial owners and misclassifying a partial flash attempt.Change: Worker now records the timeout termination cause, keeps the operation/generation active while the OS process terminates, and publishes a single timeout result only after
finishedor aFailedToStartacknowledgement has confirmedQProcess::NotRunning. A post-timeout latestartedis killed without restarting timers. Worker state is reset before terminal signals. Existing absolute supervisor deadline and failsafe retirement owner remain unchanged.Evidence: Adds a real subprocess timeout/reuse regression to the existing S8 deterministic session harness. Runs a hung copy of the harness, verifies QProcess is already NotRunning when timeout arrives, then proves a clean second launch using a new generation. No extra CI workflow and no firmware engine rewrites.
Safety: No implicit flash/retry, SV/PTP restart, forced firmware update, unverified READY, or change to stable M3.H.3. No overlap with open M4 roster #350 or autonomous LAN #330. Hardware qualification still pending.
Merge gate: exact-head Qt/S8, Windows, C++, Security and other applicable CI green; do not count cancelled/skipped as pass.