Repository navigation
fix(ci INT-1): refresh required gate after exact-head manual Chromium completion - #839
Merged
masarray merged 2 commits intoNov 20, 2026
Merged
Conversation
…thout PR event linkage
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 20, 2026
Open
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause and measured regression — INT-1A #836 / issue #823
On exact qualified combined G-MV/N-MOD source
3bc60cebf5a4d94e310285f9f07e89a441caeb4a, Full Chromium run 44677094222, Windows FAT run 44677134203, and scoped quick tests all completed SUCCESS, but Required CI Merge Gate remainedpending: nativeFull/uiFull not dispatched. Owner had to manually rerun one successful Fast UI job136090640207just to get a trusted pull_request workflow_run event; only then did Required Gate publish SUCCESS and #836 merge as76206d812760012353802dae417f213af754c3b1.Actual fix (no audio/GUI or release logic changed)
Trusted main-owned publisher recognizes a missing-PR manual UI workflow_run completion only when its immutable path is
.github/workflows/ui-smoke.yml, event isworkflow_dispatch, and its exact 40-hexhead_shacorresponds to a GitHub-verified, currently OPEN, main-targeted PR of this same repository. Then it recomputes all required lanes from the actual job API, not the event result, so failed, skipped or duplicated jobs still deny merge. Retains historical automatic pull_request fallback with restricted known workflow identities; unrelated manual native/release/custom workflow events cannot trigger this association path.Regression & acceptance
tests/required_pr_merge_gate.test.mjs: positive missing-PR manual UI, stale SHA, closed/wrong-base/wrong-repo PR, duplicate, untrusted workflow/event.src/,web/,engine/,CMakeLists.txtor audio code. Usenode --test tests/required_pr_merge_gate.test.mjsand protected source-contract gate, with no redundant Windows or Chromium runner on CI-only edits, per AGENTS.md.