Repository navigation
Conversation
… from ConsoleWindow
|
@codex review Review exact HEAD |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
535d3f4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d517fb4b.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-nmod19-direct-devic.arsonmix.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ae228b84c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review Review revised EXACT head |
|
/arsonmix-ci native 535d3f4 |
|
Codex Review: Didn't find any major issues. 👍 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
N-MOD-19 — Native DIRECT device recovery coordinator (second major domain)
Independent dedicated Device-side integration PR, branched from
main@b30a59303ad3aed486a141c96acc42dec00d2caa. This Native device refactor is intentionally separate from N-MOD-14–18 Player #799, whose exact Windows qualification is running. Do not merge/cherry-pick across active GUI/Native branches without checking latest main and both PR HEADs.Actual extraction
ConsoleWindow::serviceDirectRestoretosrc/NativeDirectRestoreCoordinator.h, with one borrowedLiveAudioEngineand oneDirectRestoreBackoff.ConsoleWindowsimply wires diagnostics/notification sinks, retains explicit cancel operations and accepted device/readback.directRestoreState/ attempts / generation / remaining time / error / pending snapshot projection into the same coordinator; preserve original JSON field names and exact operator messaging.setIndependentClockEnabled(false), only on JUCE CONTROL.DirectRestoreBackoffremains the bounded and generation-safe retry source of truth; leave independent-clock watchdog / direct ASIO fastpath unchanged.Tests and measurable coupling
NativeDirectRestoreBoundedRetryAndFaultEvidenceCTest with fake device: idle, fault and immediate attempt, deferred 250ms retry, recovered DIRECT/retained mute, no repeat, pending direct restoration, 5-attempt exhaustion, no further reopen and snapshot compatibility; verify watchdog evidence precedes truncated full JSON.ARMixMixerRoutingTestsWindows target.Main.cppreduces 70 real lines in this extraction; no pass-through adapter duplication. Four source/test files changed.9ae228b84c91b530a1c157c7ba39e93f88b1e0c9. Source code committed, Fast Native / MSVC / CTest not yet verified; hardware ASIO FAT and installer NOT RUN. Separate from Player branch; require fast native + one exact-SHA Windows CTest + protected gate at latest reconciled main before merge.Owner handoff: HASIL = Device recovery now a testable single-authority control service; STATUS KODE DIBUAT (not compiled/merged). AMAN DIPAKAI? Current main unaffected, new source BELUM. TINDAKAN USER = TIDAK PERLU. NEXT: fast checks+Codex review, then reconcile and qualify once with appropriate Native merge.