Repository navigation
fix(g-mv25): immediate native authority recovery despite pending v6 GUI ACK - #807
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c66fcb9946
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Deploying arsonmix with
|
| Latest commit: |
3ee388a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://61f081bf.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-g-mv25-controller-a.arsonmix.pages.dev |
|
/arsonmix-ci ui 3ee388a |
G-MV25 — Indonesian owner handoff / 19 November 2026(1) Operator outcome. Native GUI now immediately recognizes an authoritative PCM producer transition such as admitted ChannelId → M4/UNADMITTED at unchanged device epoch and canonical hardware pin/format fingerprint. Previously, a pending un-ACKed v6 fader/WIRE/FX intent could suppress the replacement accepted callback entirely. A previously ACKed control would reject an unadmitted snapshot rather than repaint that replacement promptly. The existing one-controller (2) Status: MERGED MAIN. PR #807 squash SHA (3) Safety: Pure same-device authority transitions now report (4) Owner action: NOTHING REQUIRED for merged code milestone. No new installer or ASIO hardware field FAT was performed. GUI/contract QA is not a claim of physical speaker playback qualification. (5) Exact-SHA evidence:
(6) Next recommendation: G-MV26 should address any measurable same-epoch device/authority recovery revision ambiguity at the native producer contract boundary with monotonic generation/epoch evidence, rather than relaxing current anti-replay revision guards. Prioritize staged repro/tests, keep N-MOD Player and IO1 separate; never accept lower-revision old PCM without authenticated/monotonic producer generation. |
G-MV25 — Fix the v6 native controller's same-epoch producer switch fence
Verified root cause
createController.onSnapshot()previously cancelled a pending GUI intent on device epoch change, retained NEEDS_REMAP, or physical pin/format change, but not when an admitted ChannelId native PCM producer became M4/UNADMITTED at the same device epoch and hardware fingerprint. With a pending un-ACKed edit, the shared controller's optimistic-protection gate suppressed the newly accepted native snapshot and the bridge could not execute its existing authority-change cleanup. With an ACKed edit, an unadmitted new snapshot returned false instead of immediately publishing the replacement source. In both cases the operator GUI could remain on the old read-model until another snapshot or timeout.Implementation
authorityChangedcomparison in the existing schema-v6 controller, covering changes of the authoritative session marker or actual admitted/non-admitted PCM ownership. Clear the old pending v6 lease before the existing!pending.ackdisplay freeze and call the unchangedonAcceptedpipeline. This lets G-MV24's existing DeviceVM lifecycle fence drop all old SOURCE/FX/WIRE/output leases in the very same callback.Only
web/approved-native-contract.jsand existing Node source-contract test changed. No native JUCE, driver, DSP,.smix, UI layout or N-MOD branch modification. Fast UI/native and one exact-SHA Full Chromium/preview/must pass with Required Merge Gate before squash merging. No Windows physical ASIO FAT claimed.