Repository navigation
refactor(g-mv24): unify retained/reconnect GUI transient cleanup - #806
Conversation
…ative source scheduling policy
…p with safe M4 scheduling
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
36929d5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3ed7010c.arsonmix.pages.dev |
| Branch Preview URL: | https://refactor-g-mv24-retained-rea.arsonmix.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 647de6a077
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
/arsonmix-ci ui 36929d5 |
G-MV24 — Owner completion / handoff (19 Nov 2026, WIB)1. Outcome / operator: On reconnect, device swap or ChannelId authority change, SOURCE, FX, WIRE, EXTERNAL OUT, M4 controls, native slider gestures and other transient UI transactions all use one complete invalidation path. During repeated 2. Status: MERGED MAIN on protected PR #806, squash SHA 3. Safety scope: Source/UI contract and approved 4. Owner action: Nothing required for code milestone. New Windows installer/hardware field validation remains a separate user-test activity. 5. Exact-SHA evidence:
6. Next G-MV: Audit reconnect and retained AUTHORITY recovery from initial retained graph back into ChannelId/M4 for timing races, including ensuring only accepted readback releases deferred input edits and never restores old physical output arming. Prefer targeted ViewModel pure policy and tests rather than additional duplicated bridge state. Keep ONE |
G-MV24 — One retained/reconnect GUI lease cleanup, preserving legal metadata writes
Audited defect
On G-MV23 main, device/authority changes called a complete
expireTransientNativeUi()cleanup whileNEEDS_REMAPhad a second, partial pending-transaction cleanup list. Repeated retained snapshots could leave M4, FX/global/slot bypass, external output, WIRE, and other physical UI leases in inconsistent states. Before checking the authority, the bridge could also schedule redundant M4 SOURCE queue microtasks from retained snapshots.Final implementation
discardTransientNativeUi({preserveRetainedIdentity=false})is the only complete cleanup owner for transient GUI SOURCE/M4/FX/WIRE/output/track actions. An actual physical device or authority change callsexpireTransientNativeUi()and rejects previous pending ChannelId identity edits as well.NEEDS_REMAPsnapshots use the same complete audio-lease discard silently, preserving the retained-graph paint signature to avoid repeated DOM rebuilding.NEEDS_REMAPstill permits native cosmetic ChannelId name/color/icon writes and cache migration. The retained cleanup preserves same-leasependingIdentityso its independent ACK + appearance readback can finish. On a real hardware/authority switch the default cleanup still invalidates old identity writes.deviceVM.nativeTransientReadbackPolicy(kind)permits SOURCE drain only for matchingCHANNEL_ID,M4, or preparedUNADMITTEDfirst-sound authority; not forNEEDS_REMAP,STALE,LOGICAL_ONLY, orINVALID.Architecture / verification
ONE approved
/preview/, ONE schema-v6 controller, ONE native PCM owner/transport, accepted ChannelId/EdgeId and M4 compatibility. Does not alter native DSP/VST3, hardware drivers,.smix, CSS/layout, or automatically arm speakers. Exact-head Fast UI/native, Full Chromium, Required Merge Gate and clean squash merge are mandatory. No physical ASIO FAT or new Windows installer claimed; parallel N-MOD untouched.