Repository navigation
refactor(mv7): settle native SOURCE only after ACKed exact PCM readback #783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
masarray
merged 5 commits into
main
from
refactor/mv7-native-source-readback-settlement-20261118
Nov 18, 2026
+170
−13
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
596df02
refactor(mv7): verify native SOURCE ACK revision and independently in…
masarray 48ce274
refactor(mv7): hold native SOURCE transaction through correlated PCM …
masarray f1da56e
test(mv7): prove SOURCE ACK not PCM; exact pins, revision and queued …
masarray fed78a3
fix(mv7): reject mismatched session authority/epoch and non-advancing…
masarray 774c9a8
test(mv7): reject mismatched session generation and non-advancing ACK…
masarray File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If another native edit advances the graph before the ACKed revision is observed, this comparison accepts the later snapshot as proof of the SOURCE request. For example, an ACK for revision
6followed only by revision7with matching pins returnsCONFIRMED, causingsettleNativeSourceReadbackto report verified PCM and release the next queued edit without observing revision6. The existing controller inweb/approved-native-contract.jsinstead treats readback beyond the ACK revision as conflicting. Require exact revision equality and handle a superseding revision as a conflict/refresh rather than successful settlement;AGENTS.mdexplicitly requires a matching ACK and same-revision native snapshot.AGENTS.md reference: AGENTS.md:L178-L178
Useful? React with 👍 / 👎.