Skip to content

fix(ImmerSIB): native concert editor opens reliably and survives VST3 editor switching - #742

Merged
masarray merged 2 commits into
mainfrom
fix/immersib-editor-open-lifetime-vst3-20261117
Nov 17, 2026
Merged

masarray merged 2 commits into
mainfrom
fix/immersib-editor-open-lifetime-vst3-20261117

Conversation

@masarray

Copy link
Copy Markdown
Owner

User-reported regression (public Windows alpha.24)

On a live CH02 FX Rack with dearVR PRO 2 → Compressor → ImmerSIB:

  • Clicking ImmerSIB displays an irrelevant “Effect settings updated” toast, not the visible JUCE concert GUI.
  • Opening a VST3 editor closes the ImmerSIB editor; subsequent ImmerSIB clicks do not reliably reopen it.

Root causes and fix

  1. arMixRoutingFxEditorAck success was being passed to generic FX settings status translation. A successful floating-editor open now generates no fake settings toast, while failure is still shown explicitly.
  2. The approved JS FX Rack uses an explicitly identity-bound, admitted-graph routingFxEditor action for armix.builtin.imersip.v1 rather than inadvertently treating this native JUCE UI as a WebView2 SonKu editor.
  3. Main.cpp used one editorWindow_/lease for every routed VST3 and ImmerSIB. A new unrelated VST3 click would dispose the concert JUCE window before focusing the new editor. Now the ImmerSIB editor has a separate JUCE DocumentWindow + exact PCM instance lease/epoch; refocusing the same accepted instance calls present(), vendor VST3 windows can be switched independently, and retired leases are still closed fail-closed. Structural graph changes and shutdown close both windows before releasing processors.
  4. Existing audio DSP math, SonKu P9.9 golden tuning, ImmerSIB concert presets, FX processor identities, .smix state, and the single PCM graph remain untouched.

Tests

  • Extended tests/native_fx_window_lifecycle_contract_test.py for dedicated JUCE window, refocus, independent vendor window, lease retirement, disposal order.
  • Extended tests/imersip_p92_catalog_contract_test.py for explicit accepted editor route and no false toast.
  • Extended existing native JS/host integration contract tests/approved_native_m2_contract.test.cjs.

Validation

Review native Windows JUCE build and editor owner FAT before merge. Do not auto-publish another release without a successful Windows test. Manual alpha field test: CH02 real ImmerSIB click, click dearVR, return to ImmerSIB, close/reopen both, bypass/rack/global power and device restart.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T04:26:02.352054Z 0a7427c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: cb68489
Status: ✅  Deploy successful!
Preview URL: https://493b8973.arsonmix.pages.dev
Branch Preview URL: https://fix-immersib-editor-open-lif.arsonmix.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0a7427c3d7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/Main.cpp
Comment on lines +6612 to +6615
if(shownWindow && shownOwner==owner &&
shownEpoch==retainedEpoch &&
shownProcessor==owner->processor.get()) {
shownWindow->present();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update existing lifecycle assertions for the aliased editor state

The refactor to shownOwner/shownEpoch leaves existing source-contract tests asserting the removed expressions. Running python3 tests/native_fx_window_lifecycle_contract_test.py fails on routedEditorOwner_==owner, and node --test tests/approved_native_m2_contract.test.cjs fails on routedEditorEpoch_=retainedEpoch; the parent lifecycle suite passes. These tests are executed by .github/workflows/native-fx-owned-editor.yml, ui-smoke.yml, and p1-windows.yml, so the change breaks qualification despite adding passing new assertions. Update the existing retention/refocus assertions to validate the aliased state while preserving their identity and disposal-order checks.

Useful? React with 👍 / 👎.

@masarray
masarray merged commit 09a64f8 into main Nov 17, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant