Repository navigation
fix(ImmerSIB): native concert editor opens reliably and survives VST3 editor switching - #742
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying arsonmix with
|
| Latest commit: |
cb68489
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://493b8973.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-immersib-editor-open-lif.arsonmix.pages.dev |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a7427c3d7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if(shownWindow && shownOwner==owner && | ||
| shownEpoch==retainedEpoch && | ||
| shownProcessor==owner->processor.get()) { | ||
| shownWindow->present(); |
There was a problem hiding this comment.
Update existing lifecycle assertions for the aliased editor state
The refactor to shownOwner/shownEpoch leaves existing source-contract tests asserting the removed expressions. Running python3 tests/native_fx_window_lifecycle_contract_test.py fails on routedEditorOwner_==owner, and node --test tests/approved_native_m2_contract.test.cjs fails on routedEditorEpoch_=retainedEpoch; the parent lifecycle suite passes. These tests are executed by .github/workflows/native-fx-owned-editor.yml, ui-smoke.yml, and p1-windows.yml, so the change breaks qualification despite adding passing new assertions. Update the existing retention/refocus assertions to validate the aliased state while preserving their identity and disposal-order checks.
Useful? React with 👍 / 👎.
User-reported regression (public Windows alpha.24)
On a live CH02 FX Rack with dearVR PRO 2 → Compressor → ImmerSIB:
Root causes and fix
arMixRoutingFxEditorAcksuccess was being passed to generic FX settings status translation. A successful floating-editor open now generates no fake settings toast, while failure is still shown explicitly.routingFxEditoraction forarmix.builtin.imersip.v1rather than inadvertently treating this native JUCE UI as a WebView2 SonKu editor.Main.cppused oneeditorWindow_/lease for every routed VST3 and ImmerSIB. A new unrelated VST3 click would dispose the concert JUCE window before focusing the new editor. Now the ImmerSIB editor has a separate JUCE DocumentWindow + exact PCM instance lease/epoch; refocusing the same accepted instance callspresent(), vendor VST3 windows can be switched independently, and retired leases are still closed fail-closed. Structural graph changes and shutdown close both windows before releasing processors..smixstate, and the single PCM graph remain untouched.Tests
tests/native_fx_window_lifecycle_contract_test.pyfor dedicated JUCE window, refocus, independent vendor window, lease retirement, disposal order.tests/imersip_p92_catalog_contract_test.pyfor explicit accepted editor route and no false toast.tests/approved_native_m2_contract.test.cjs.Validation
Review native Windows JUCE build and editor owner FAT before merge. Do not auto-publish another release without a successful Windows test. Manual alpha field test: CH02 real ImmerSIB click, click dearVR, return to ImmerSIB, close/reopen both, bypass/rack/global power and device restart.