Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ui-smoke.yml
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,9 @@ jobs:
python -m pip install --upgrade pip
python -m pip install playwright
python -m playwright install --with-deps chromium
- name: Verify Preview V2 V7 physical visual geometry and modeless mixer workflow
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
run: python tests/preview_v2_v7_visual_smoke.py
- name: Verify opt-in actual /preview/ GUI profiling, default OFF
run: python tests/approved_gui_perf_stage_a_smoke.py
- name: Validate Stage B native meter dirty-write / authoritative Pages parity
Expand Down Expand Up @@ -733,9 +736,6 @@ jobs:
run: python tests/pages_m3_operator_visual_interaction_smoke.py
- name: Run mixer UI smoke tests
run: python tests/ui_smoke.py
- name: Verify Preview V2 V7 physical visual geometry and modeless mixer workflow
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
run: python tests/preview_v2_v7_visual_smoke.py
- name: Verify V40 WIRE proximity, focus release and full-tray channel selection
if: ${{ github.event_name == 'workflow_dispatch' || (github.event_name == 'pull_request' && startsWith(github.head_ref, 'integration/product-')) }}
run: python tests/pages_wire_focus_v40_smoke.py
Expand Down
27 changes: 18 additions & 9 deletions site/preview-v2/assets/mixer-section-controls.css
Original file line number Diff line number Diff line change
Expand Up @@ -288,24 +288,33 @@
line-height:9px!important;
}

/* Route has four rows in the shared Pages/EXE renderer (title + IN/OUT/EXT).
Compact internal spacing rather than clipping the live EXT control or
inflating the panel: rail and strip retain their shared 94/91/81px heights. */
/* One shared four-row route geometry (title + IN/OUT/EXT) for
/preview/ and JUCE WebView2. Earlier physical chrome locked the legacy
three-row field height at 24px!important; override only expanded routes.
Keep rail heights, MAX three hardware destinations, and collapsed
23px state unchanged. Geometry budget at comfort: 17 + 3*22 + 3*1
+ 2*2 = 90px within the 94px route panel. */
.console-body:not(.collapsed-route) .strip .route-section{
padding:2px 6px 2px;gap:1px;
padding:2px 4px!important;gap:1px;
}
.console-body:not(.collapsed-route) .strip .route-field{
height:22px!important;min-height:22px!important;flex:0 0 22px!important;
}
.console-body[data-density="standard"]:not(.collapsed-route) .strip .route-field{
height:21px!important;min-height:21px!important;flex:0 0 21px!important;
}
.console-body[data-density="standard"]:not(.collapsed-route) .strip .route-select{
height:21px;
height:21px!important;min-height:21px!important;line-height:19px!important;
}
.console-body[data-density="compact"]:not(.collapsed-route) .strip .route-section{
padding:1px 3px;gap:1px;
padding:1px 3px!important;gap:1px;
}
.console-body[data-density="compact"]:not(.collapsed-route) .strip .route-top{
height:15px;min-height:15px;flex-basis:15px;
height:15px!important;min-height:15px!important;flex:0 0 15px!important;
}
.console-body[data-density="compact"]:not(.collapsed-route) .strip .route-field{
min-height:18px;
height:18px!important;min-height:18px!important;flex:0 0 18px!important;
}
.console-body[data-density="compact"]:not(.collapsed-route) .strip .route-select{
height:18px;
height:18px!important;min-height:18px!important;line-height:16px!important;
}
18 changes: 14 additions & 4 deletions tests/preview_v2_v7_visual_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,16 @@ def audit_geometry(page, title):
if(!cap||Math.abs(r(cap).width-cw)>.75||Math.abs(r(cap).height-ch)>.75)
problems.push('M2 '+cw+'x'+ch+' physical fader cap missing '+tag);
const route=t.querySelector('.route-section');
if(route&&route.scrollHeight>route.clientHeight+3)
problems.push('IN/OUT clipped '+tag);
if(route&&route.scrollHeight>route.clientHeight+3){
const cs=getComputedStyle(route);
const children=[...route.children].map(e=>{
const b=r(e);
return e.className+':'+Math.round(b.height)+'@'+Math.round(b.top-r(route).top);
}).join(',');
problems.push('IN/OUT/EXT clipped '+tag+' scroll='+route.scrollHeight+
' client='+route.clientHeight+' padding='+cs.padding+
' gap='+cs.gap+' children=['+children+']');
}
if(!t.querySelector('.meter-box .vu-bars'))problems.push('missing meter '+tag);
if(t.querySelector('.eq-section,.trim-section,[data-field="sendPan"]'))
problems.push('legacy DAW or TRIM UI leaked '+tag);
Expand Down Expand Up @@ -316,8 +324,10 @@ def audit_p0_pan_center(page, name):
return read();
};
const initial=read();
// Current approved V61 PAN: capture ±14, hold ±22, release ±18.
// The V7 expectation at 18 sat inside the newer hold zone.
const farLeft=send(-35),capture=send(-6),held=send(10),
released=send(18),nearRelease=send(11,'change');
released=send(24),nearRelease=send(17,'change');
input.dataset.panAltPointer='true';
const bypass=send(5);
delete input.dataset.panAltPointer;
Expand All @@ -331,7 +341,7 @@ def audit_p0_pan_center(page, name):
p=result[key]
assert p['value']==0 and p['centered'] and p['label']=='C' and p['text']=='Center',(
name,key,'PAN center detent failed',result)
assert result['released']['value']==18 and not result['released']['centered'],(
assert result['released']['value']==24 and not result['released']['centered'],(
name,'PAN release threshold failed',result)
assert result['bypass']['value']==5,(name,'Alt-pointer center bypass failed',result)
assert result['unchanged'],(name,'PAN remounted during gesture')
Expand Down
Loading