Skip to content

GUI: shared Preview/EXE console layout, fader law and gain material harmony - #703

Merged
masarray merged 11 commits into
mainfrom
fix/console-visual-parity-20261115
Nov 14, 2026
Merged

masarray merged 11 commits into
mainfrom
fix/console-visual-parity-20261115

Conversation

@masarray

Copy link
Copy Markdown
Owner

Operator-visible outcome

Preview and compiled Windows JUCE WebView2 now use the same route/EXT DOM, route section geometry, physical fader dB-to-travel mapping, and subdued steel/cyan GAIN surface. The browser EXT selector is visible but disabled (never a fake audio output); only the native bridge supplies real hardware choice/ACK.

Root cause verified

The supplied executable reports v0.5.0-dev+g751ff03f, matching old SonKu P8.2 draft PR #695. Baseline main was 727dbce8. The screenshots also use different GAIN/FX modes, sessions, and visible channel banks. Comparing pixels requires exact SHA, viewport, session, and mode parity.

Implementation

  • Share the EXT row for each non-MASTER strip in canonical Pages; no native-only DOM splicing.
  • Share route height/external field CSS, avoiding native-only visual overrides.
  • Share calibrated native fader taper, inverse pointer position, ticks, and unity detent in approved Pages source.
  • Harmonize GAIN LED/pointer/LCD to muted steel/cyan, retaining original photographic PNG, dimensions, relative drag and native ACK.
  • Add Chromium route geometry assertions and native source parity contracts.

Safety

No DSP/C++/device-routing changes, no SonKu merge, no release claim. Fast UI contracts + deliberate exact-head Chromium are the qualification path. The older EXE does not self-update; a newly qualified native package is required.

…d subdued gain styling

Render EXT rows in the single approved Pages source with browser-only hardware disabled, share routing heights and chrome across WebView2/Pages, reuse native tapered travel in both contexts, and harmonize GAIN metal/LED/LCD to the fader color system. Preserve native ACK/readback, WIRE DSP, PNG knob, zero-detent and snapshot behavior. Add parity/Chromium assertions.
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 01eeea6
Status: ✅  Deploy successful!
Preview URL: https://d7235e3d.arsonmix.pages.dev
Branch Preview URL: https://fix-console-visual-parity-20.arsonmix.pages.dev

View logs

…unity pointer position

Keep hardware ACK tests intact; fader taper and EXT CSS now belong to canonical Pages, so regression guards must inspect the shared source. Update browser tactile unity test to the same 77% scale used by EXE.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 74ee112

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 39efa07

…utton

Legacy helper upgrades SOLO SVG, but approved PFL uses data-hw-kind=pfl / data-action=cue and a PNG in assembled Pages. Check the current semantic fallback instead of the removed cue-key SVG.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 749deea

…ntics

Keep historical MUTE and SOLO SVG/CSS coverage; replace retired two-SVG cue assumptions with approved semantic PFL checks. Assembled /preview/ PNG artwork stays authoritative. No GUI or PCM changes.
…fallback

Historical raw Pages uses one SOLO SVG. The real PFL button is PNG-owned in assembled /preview/, not a second SVG. Keep independent mute/solo/PFL action checks.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui cf2abc8

Copy link
Copy Markdown
Owner Author

Independent GUI parity audit — operator screenshots (2026-11-15)

Reviewed cf2abc8411771d89b102437cf4dc2ab6a4b88de0 against the provided Pages GAIN screenshot and Windows v0.5.0-dev+g751ff03f FX screenshot. Confirmed the PR correctly removes native-only EXT markup/route-height styling and native-only fader travel law, while moving subdued cyan/steel GAIN palette to the shared Pages CSS. Exact-head UI smoke and fast PR CI report SUCCESS; the PR is still DRAFT and unmerged.

Release/parity acceptance still required: (1) build native Windows EXE from this exact PR/main integration source, not the older P8.2 package; (2) compare at identical window size, bank/channel set, .smix snapshot, selected GAIN versus FX RACK mode and routing/device conditions; (3) screenshot-compare route field/rail heights, EXT row, GAIN LCD/knob, fader tick + thumb positions at -36/-12/0 dB, active hardware buttons and MASTER; (4) confirm the disabled browser EXT control differs from native only in capability/state, never geometry; (5) verify installed JUCE/VST3/native ACK and device-related UX separately; no physical audio FAT conclusion from browser smoke.

Code maintenance follow-up: shared route geometry has --route-h:94px!important and density-specific !important near the end of mixer-section-controls.css. Consider consolidating into the existing shared route-height token owner rather than introducing more competing important overrides (but avoid destabilizing this already-tested visual change). Preserve previous accepted GAIN gesture/PNG, channel identities, WIRE edges, FX plugin GUI, and SonKu P8.2 audio baseline; never merge rejected P8.3 to obtain a GUI update.

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 21bb5da

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 40108fa

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui aa479d0

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 9039264

Copy link
Copy Markdown
Owner Author

/arsonmix-ci ui 01eeea6

@masarray
masarray marked this pull request as ready for review November 14, 2026 21:34
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-14T21:34:34.637197Z
We couldn’t complete this review. Comment @codex review to try again.
01eeea6 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit 9df390b into main Nov 14, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant