Repository navigation
feat(player): M5 reconcile musical KEY/TEMPO DSP with M4 cue, dual-deck and realtime safety - #682
Merged
Conversation
…how deck Forward-port vetted worker-only high-overlap DSP and focused waveform/gesture/EOS suites. Drain Signalsmith input and output latency through M4 native cue OUT without restoring outdated decoder state. Add real JUCE cue/pitch EOF test; preserve waveform, dual-deck queue/ACK, physical routing and Vocal Harmony isolation.
masarray
marked this pull request as ready for review
November 14, 2026 04:57
Deploying arsonmix with
|
| Latest commit: |
d03fb5a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7467b72e.arsonmix.pages.dev |
| Branch Preview URL: | https://feat-player-m5-quality-m4-re.arsonmix.pages.dev |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Nov 14, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
M5 — KEY/TEMPO musical DSP integrated with already merged M4, no old-decoder overwrite
Base:
main@b3ca20bafe08f2f62104d7f2df57bd4c723751a2. One focused commit:d03fb5a65e96691c4b07c961b8f19b3bad2b6bf7.Implemented
presetDefault, worker-only smooth pitch and sample-rate-independent tempo, bounded 5ms parameter boundary correction, dry→processed spectral priming, normal neutral path, two-sided EOF latency accounting.NativePlayerDeck.h. Use the worker's actual smoothed tempo for drain frame sizing and retain cue OUT as the source-media boundary.NativePlayerShowDeck.h,src/Main.cpp, mixer/FX/PCM callback, approved /preview/ GUI, Vocal Harmony plugin, public release/installer.Qualification gates
This PR is a code integration milestone, not a claim of parity with Ableton/élastique or field-qualified physical ASIO. Prior #675 is superseded for integration only after this branch is qualified; do not merge the old branch over M4.
FINAL exact-SHA CI qualification (all green)
One authoritative native PLAYER A PCM source and approved GUI preserved. Legacy #675 is superseded to avoid overwriting merged M4.