Skip to content

feat(player): M5 reconcile musical KEY/TEMPO DSP with M4 cue, dual-deck and realtime safety - #682

Merged
masarray merged 1 commit into
mainfrom
feat/player-m5-quality-m4-reconcile-20261114
Nov 14, 2026
Merged

masarray merged 1 commit into
mainfrom
feat/player-m5-quality-m4-reconcile-20261114

Conversation

@masarray

@masarray masarray commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

M5 — KEY/TEMPO musical DSP integrated with already merged M4, no old-decoder overwrite

Base: main@b3ca20bafe08f2f62104d7f2df57bd4c723751a2. One focused commit: d03fb5a65e96691c4b07c961b8f19b3bad2b6bf7.

Implemented

  • Selective forward-port from feat(player): pro-grade KEY/TEMPO transitions, complete song tails and music-quality DSP #675: stereo-linked higher-overlap Signalsmith presetDefault, worker-only smooth pitch and sample-rate-independent tempo, bounded 5ms parameter boundary correction, dry→processed spectral priming, normal neutral path, two-sided EOF latency accounting.
  • Do not copy the obsolete feat(player): pro-grade KEY/TEMPO transitions, complete song tails and music-quality DSP #675 decoder: preserve native M4 IN/OUT, progressive waveform, media clock, M4 queue/crossfade and generation/device epoch fences.
  • Port analysis input drain and synthesis flush into M4 NativePlayerDeck.h. Use the worker's actual smoothed tempo for drain frame sizing and retain cue OUT as the source-media boundary.
  • Add one genuine JUCE WAV + cue 1.0–1.4s + KEY +3 + TEMPO 80 regression into the M4 native decode test, checking playback reaches ended, media clock remains bounded, finite PCM and audible outro.
  • Add focused standalone worker DSP suite (44.1/48/96k, ±pitch, 80/100/120 TEMPO, stereo anticorrelation, repeated hot gestures, exact neutral copy, synthesis tail) and opt-in non-gating same-runner cheap-preset comparison.
  • Unchanged: NativePlayerShowDeck.h, src/Main.cpp, mixer/FX/PCM callback, approved /preview/ GUI, Vocal Harmony plugin, public release/installer.

Qualification gates

  • Scoped Linux KEY/TEMPO C++ DSP workflow on this exact commit
  • Windows MSVC JUCE real-WAV / cue / M4 dual-deck CTest on exact commit
  • Player M1–M4 portable contracts, GUI smoke and fast native contracts when triggered
  • Inspect any failing checks; merge only after credible exact-SHA source gate
  • Hardware / sonic: physical ASIO + MIC + FX + music A/B audition remains QA: ArSon Player M1–M4 physical ASIO + music/FX field acceptance #680, not claimed by synthetic CI

This PR is a code integration milestone, not a claim of parity with Ableton/élastique or field-qualified physical ASIO. Prior #675 is superseded for integration only after this branch is qualified; do not merge the old branch over M4.

FINAL exact-SHA CI qualification (all green)

One authoritative native PLAYER A PCM source and approved GUI preserved. Legacy #675 is superseded to avoid overwriting merged M4.

…how deck

Forward-port vetted worker-only high-overlap DSP and focused waveform/gesture/EOS suites. Drain Signalsmith input and output latency through M4 native cue OUT without restoring outdated decoder state. Add real JUCE cue/pitch EOF test; preserve waveform, dual-deck queue/ACK, physical routing and Vocal Harmony isolation.
@masarray
masarray marked this pull request as ready for review November 14, 2026 04:57
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: d03fb5a
Status: ✅  Deploy successful!
Preview URL: https://7467b72e.arsonmix.pages.dev
Branch Preview URL: https://feat-player-m5-quality-m4-re.arsonmix.pages.dev

View logs

@masarray
masarray merged commit 28cffcf into main Nov 14, 2026
8 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant