Repository navigation
feat(player): M1–M4 native live show, reliable queue, cue loop and transition qualification - #676
Merged
Merged
Conversation
…rols in approved drawer
Deploying arsonmix with
|
| Latest commit: |
0034fd5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bfadee31.arsonmix.pages.dev |
| Branch Preview URL: | https://feat-player-live-show-m1-m2.arsonmix.pages.dev |
…and equal-power crossfade
…transport intents
…er-enforced song ending
Owner
Author
|
/arsonmix-ci field 43ed99f |
…ed for 80–120% tempo
…ning during WebView reload
…f playing last sample
…and no failure spin
…ent of deck generation
…EXT and never auto-plays
Owner
Author
|
/arsonmix-ci field 0034fd5 |
11 tasks
masarray
marked this pull request as ready for review
November 14, 2026 04:29
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArSon Player — Live Show M1–M4 (one native PCM authority)
Feature PR off
main@4a6e47e. Dedicated KEY/TEMPO quality PR #675 remains separate; this PR does not rename or modify the built-in vocal Harmony plugin.M1 — Professional setlists and operator-safe queue
player-library.json, with bounds checking and non-destructive migration from v1/v2; per-song KEY/TEMPO and cue metadata/preview/GUI, no new modal wizard, no frontend playbackM2 — Native musical navigation and cues
M3 — Warm NEXT and controlled crossfade
NativePlayerShowDeckowns two background decoding workers, one old track and one preloaded NEXT; the audio hardware callback still sees exactly ONEDynamicPlayerPcmBlockfor existing PLAYER A ChannelId, FX, WIRE, BUS and MAINTargeted regression and evidence
tests/player_show_edit_policy_test.cpp: exhaustive stable-ID reorder/remove/undo mappingtests/player_waveform_index_test.cpp: bounded wave bins, thread-safe snapshots and corruption guardtests/player_crossfade_curve_test.cpp: equal-power gain endpoints/interpolation bounds, finite valuestests/player_native_decode_test.cpp: extended genuine WAV/JUCE source tests for seek, waveform, standby to real PCM fade, device epochKnown limits / NOT claiming complete
mainpitch engine still uses its original DSP; feat(player): pro-grade KEY/TEMPO transitions, complete song tails and music-quality DSP #675 quality uplift must be reconciled separatelyChannelHarmonyProcessor.handtests/harmony_dsp_test.cppbit-identical tomain. Investigate independently rather than patching unrelated vocal engineWindows exact-SHA qualification — VERIFIED
FIELD Windows MSVC/JUCE run #43548283547: SUCCESS for head
a9fa518c09bdbb5fc15964248867e590ebd219ff:ARMixConsolecompiled PASS, field ZIP packaged and independently verified PASSArSonMix-Windows-Field-Preview-a9fa518c09bdbb5fc15964248867e590ebd219ff(download from run page)M1-M3 next milestone: transactional queue, deadline-based transition, rehearsal A-B
Source commit
43ed99f03a876cfce60ffbcdb21154509eba2957:PlayerShowTransitionPolicy.h(portable C++ policy),tests/player_show_transition_policy_test.cpp, new real WAV dual-deck same-file A-B regression and STOP cancellation intests/player_native_decode_test.cpp.ARMixPlayerDecodeTestsand one CTest; NO installer, NO entire CTest catalog, NO dedicated ASIO hardware runner.Qualification boundary: Focused real WAV/JUCE tests PASS on Windows for final M4 source. Physical ASIO + singer/mic + FX audition and dropout soak remain unproven and are tracked in #680. Full-song waveform cache is not implemented: 256 progressive bins are collected during decoding only. The 12 Hz deadlines are bounded control-timer decisions, not sample-accurate gapless certification. PR #675 pitch/tempo quality uplift remains separate.
Native JUCE and Windows proof on exact M1-M3 HEAD
43ed99f03a876cfce60ffbcdb21154509eba2957.ARMixPlayerDecodeTestscompiled andArSonPlayerRealWavDecodeResampleAndTransportpassed 1/1, including real same-file two-deck A-B fade and STOP cancellation.M4 — native live-show reliability closure
Source and regression head
0034fd5e5f20fe35900c95ae0868cc6148e8d0df. M4 is reliability/qualification, not an additional DSP/FX/routing engine:ArSonMix-Windows-Field-Preview-0034fd5e5f20fe35900c95ae0868cc6148e8d0df(14.6 MB; download from run). Source SHA verified by the Windows job before build; this is NOT the older43ed99fbuild.Boundary: No physical singer MIC/ASIO/FX/BUS/MAIN device or long-duration dropout soak was available to certify; do not claim it. Full-song offline waveform cache, sample-accurate gapless, arbitrary per-song VST3 preset snapshots and PR #675 musical pitch/tempo quality uplift remain separate optional follow-up tracks rather than being silently marked done.