Skip to content

feat(player): M1–M4 native live show, reliable queue, cue loop and transition qualification - #676

Merged
masarray merged 81 commits into
mainfrom
feat/player-live-show-m1-m2-m3-20261114
Nov 14, 2026
Merged

masarray merged 81 commits into
mainfrom
feat/player-live-show-m1-m2-m3-20261114

Conversation

@masarray

@masarray masarray commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

ArSon Player — Live Show M1–M4 (one native PCM authority)

Feature PR off main@4a6e47e. Dedicated KEY/TEMPO quality PR #675 remains separate; this PR does not rename or modify the built-in vocal Harmony plugin.

M1 — Professional setlists and operator-safe queue

  • Persist multiple named setlists as crash-safe version 3 player-library.json, with bounds checking and non-destructive migration from v1/v2; per-song KEY/TEMPO and cue metadata
  • Create/select/rename/delete setlists, reorder rows with drag or keyboard buttons, remove + Undo (never delete underlying media), Play Next/Add Queue/remove from queue
  • Queue references real media paths, remap CURRENT/SELECTED/pending song indexes on edits; switching sets is blocked while media is playing or paused
  • One approved /preview/ GUI, no new modal wizard, no frontend playback

M2 — Native musical navigation and cues

  • Genuine JUCE decoder worker seek with generation fencing and prebuffer; no random I/O in ASIO audio callback, no stale PCM on a seek
  • A bounded 256-bin source waveform populated progressively in the existing decode pass, exported as atomic snapshot to a compact canvas; no full-song second reader/scan
  • Per-song persistent, non-destructive IN/OUT trims, Go IN, Set IN/OUT, Clear markers
  • Source-media timeline separate from tempo-stretched output EOF counters for meaningful seek/cue positions at KEY/TEMPO changes

M3 — Warm NEXT and controlled crossfade

  • NativePlayerShowDeck owns two background decoding workers, one old track and one preloaded NEXT; the audio hardware callback still sees exactly ONE DynamicPlayerPcmBlock for existing PLAYER A ChannelId, FX, WIRE, BUS and MAIN
  • Standby prebuffer cache bounded to current device epoch; prepare/stop/seek/retire only on worker/control; callback reads bounded SPSC buffers
  • Controls for Cut, Smooth 180ms, Crossfade 500ms, Crossfade 1500ms; immutable equal-power curve table, preallocated 2×8192 stereo scratch, no callback trigonometry or disk I/O
  • Control-timer transition ACK changes CURRENT only after genuine standby PCM ready; decode error retains old CURRENT; STOP/pause cancel pending changes
  • Existing microphone monitoring, routing decisions and output identity remain untouched

Targeted regression and evidence

Known limits / NOT claiming complete

Windows exact-SHA qualification — VERIFIED

FIELD Windows MSVC/JUCE run #43548283547: SUCCESS for head a9fa518c09bdbb5fc15964248867e590ebd219ff:

  • Fast native contracts PASS; MSVC CMake configure PASS, one approved GUI bundle verified, actual ARMixConsole compiled PASS, field ZIP packaged and independently verified PASS
  • GitHub Actions artifact: ArSonMix-Windows-Field-Preview-a9fa518c09bdbb5fc15964248867e590ebd219ff (download from run page)
  • Field preview does not run the full 90+ CTest; a separate scoped Windows JUCE WAV test is required and is now PASS at the final M4 SHA. No physical audio/ASIO soak is claimed.

M1-M3 next milestone: transactional queue, deadline-based transition, rehearsal A-B

Source commit 43ed99f03a876cfce60ffbcdb21154509eba2957:

  • M1: Queue can be reordered via small up/down controls; decoder/source failure cannot consume queue; queued repeat of CURRENT uses standby rather than an accidental Play/resume. The front entry is removed only on actual native decoder/fade acknowledgement.
  • M2: Opt-in rehearsal Loop A–B (default OFF, not silently persisted). IN/OUT and loop length validated, no callback seek, same-media standby worker uses a >=40ms equal-power fade to restart the segment. Explicit Next escapes the loop without discarding the operator queue.
  • M3: Auto Next checks original-media time at a bounded 12 Hz transport cadence and arms fade ahead of EOF. A queue head is preloaded even when Auto Next is OFF. Generic GUI snapshots continue at the prior 4 Hz cadence; no heavyweight callback work.
  • Correctness: Added PlayerShowTransitionPolicy.h (portable C++ policy), tests/player_show_transition_policy_test.cpp, new real WAV dual-deck same-file A-B regression and STOP cancellation in tests/player_native_decode_test.cpp.
  • Focused CI: Player native fast suite PASS, GUI quick contracts PASS, general native quick PASS. Vocal Harmony plugin CI no longer triggers on player work.
  • Windows JUCE only-player target: Focused native decoder test run on the same immutable source. This lane is deliberately limited to ARMixPlayerDecodeTests and one CTest; NO installer, NO entire CTest catalog, NO dedicated ASIO hardware runner.

Qualification boundary: Focused real WAV/JUCE tests PASS on Windows for final M4 source. Physical ASIO + singer/mic + FX audition and dropout soak remain unproven and are tracked in #680. Full-song waveform cache is not implemented: 256 progressive bins are collected during decoding only. The 12 Hz deadlines are bounded control-timer decisions, not sample-accurate gapless certification. PR #675 pitch/tempo quality uplift remains separate.

Native JUCE and Windows proof on exact M1-M3 HEAD

M4 — native live-show reliability closure

Source and regression head 0034fd5e5f20fe35900c95ae0868cc6148e8d0df. M4 is reliability/qualification, not an additional DSP/FX/routing engine:

  • Repeat stability: Remove per-decoder generation equality as the loop gate. A/B may publish identical numeric generations; a native outstanding-ACK state now drives successive Loop A-B transitions. Retire the completed old decoder before a rapid subsequent preload, avoiding late STOP of freshly cached PCM.
  • Tempo-aware deadlines: Original song/media time is converted at applied TEMPO (80–120%) before scheduling Auto Next or A-B overlap. CUT remains end-only; no claim of sample-accurate zero-gap crossfade.
  • Transactional Auto Next: A small pure C++ logical gate tracks one attempted transition per song segment. A real native ACK rearms the next (including identical queued file/index), whereas decode failure remains latched until the user changes the queue/requests retry (no rapid error/retry loop).
  • WebView independence: JUCE's control timer continues transition ACK, looping and Auto Next while Chromium reloads/unloads. WebView only controls GUI status publication. A lightweight Node contract verifies this ownership and the 12 Hz rehearsal-loop cadence even with Auto Next OFF.
  • Cue/relink resilience: A saved IN marker beyond a relinked file's real duration emits an explicit native failure rather than reporting an almost-silent one-sample 'success'. Reload with a repaired cue succeeds.
  • Device epoch proof: Native test covers 96 kHz -> disconnect -> 44.1 kHz while NEXT is pending. Stale standby is cancelled and reconnect requires an explicit Play; no auto-unmute or second device authority.
  • New native WAV tests: 4 consecutive same-file loop fades without manual retirement in between; genuine JUCE WAV seek, live pitch/tempo, transition and cancellation; invalid cue recovery and device epoch. Portable pure-C++ test additionally covers 7 consecutive same-song logical Auto Next ACKs.
  • All relevant exact-SHA checks: Windows MSVC/JUCE native real-WAV SUCCESS, scoped player M1-M4 SUCCESS, Chromium SUCCESS, fast native contracts SUCCESS. No Vocal Harmony plugin CI triggered.
  • Portable field-preview from exact SHA — SUCCESS: Windows MSVC/JUCE build, approved /preview/ GUI and independent ZIP verification. Verified GitHub artifact: ArSonMix-Windows-Field-Preview-0034fd5e5f20fe35900c95ae0868cc6148e8d0df (14.6 MB; download from run). Source SHA verified by the Windows job before build; this is NOT the older 43ed99f build.
  • Physical acceptance: #680 — hardware MIC/ASIO/music/FX show test matrix. Software CI has passed; no physical ASIO claim or UX ear-test certification.

Boundary: No physical singer MIC/ASIO/FX/BUS/MAIN device or long-duration dropout soak was available to certify; do not claim it. Full-song offline waveform cache, sample-accurate gapless, arbitrary per-song VST3 preset snapshots and PR #675 musical pitch/tempo quality uplift remain separate optional follow-up tracks rather than being silently marked done.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0034fd5
Status: ✅  Deploy successful!
Preview URL: https://bfadee31.arsonmix.pages.dev
Branch Preview URL: https://feat-player-live-show-m1-m2.arsonmix.pages.dev

View logs

Copy link
Copy Markdown
Owner Author

/arsonmix-ci field 43ed99f

Copy link
Copy Markdown
Owner Author

/arsonmix-ci field 0034fd5

@masarray masarray changed the title feat(player): M1-M3 native live show setlists, wave seek/cues and warm NEXT crossfade feat(player): M1–M4 native live show, reliable queue, cue loop and transition qualification Nov 14, 2026
@masarray
masarray marked this pull request as ready for review November 14, 2026 04:29
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-14T04:29:11.576559Z
We couldn’t complete this review. Comment @codex review to try again.
0034fd5 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit b3ca20b into main Nov 14, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant