Repository navigation
fix(gui): consolidate shadowed SonKu CSS, restore main preview ownership gate - #671
Merged
Merged
Conversation
…-rack owner Keep the last effective declaration in identical selectors/media contexts; preserve important cascade and existing responsive rules. No stylesheet addition, class change or audio/GUI handler edits. Ownership duplicates drop from 76 to 4 (approved cap 8).
Prevent same-owner / cross-owner CSS layering regressions from reaching main via a green fast job while full Chromium is skipped.
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Deploying arsonmix with
|
| Latest commit: |
3a61f28
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e14d089b.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-sonku-main-css-owner-cle.arsonmix.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main post-merge regression
Following #670 main merge,
UI smoke (Chromium)full preview job fails atcheck_preview_css_ownership.pywithNEW SAME-OWNER CSS STACKING FORBIDDEN: {'mixer-fx-rack.css': (76, 8)}. The SonKu branch's fast UI checks omitted this source-owner gate, so the failure emerged only on main push.Correct fix, not a baseline bypass
Prune precisely 72 superseded CSS declarations in
.mx-sonkuselectors from the existing approvedmixer-fx-rack.cssowner. Keep the final effective winner per same selector, media context, property and CSS importance, preserving all unique declarations and media variants, and never changing artist PNGs, SVG, page, JS, WIRE or DSP.Deterministic ownership parser equivalent count drops from 76 to 4, below the existing 8 cap. The cap and production CSS owner map remain unchanged.
Move the existing cheap
scripts/check_preview_css_ownership.pyand source owner's unit test into theFast UI contractsstep before Chromium. This prevents a green scoped PR from shipping another same-owner duplication regression into main.Gate
Quick CSS ownership + Fast UI, scoped SonKu native-assembled Chromium and no regression in native picker/ACK/readback. Main full Chromium after merge is a separate release signal; no installer or tag.
CSS is source-preserving: only remove overwritten shadowed spans, so the browser-computed winning declarations are unchanged for the same selector/media context.
Source integration PR #670 and original #655 have already been merged to main; this PR repairs the one independent full-preview main guard they exposed.