Skip to content

fix(gui): consolidate shadowed SonKu CSS, restore main preview ownership gate - #671

Merged
masarray merged 2 commits into
mainfrom
fix/sonku-main-css-owner-cleanup-20261113
Nov 13, 2026
Merged

masarray merged 2 commits into
mainfrom
fix/sonku-main-css-owner-cleanup-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

Main post-merge regression

Following #670 main merge, UI smoke (Chromium) full preview job fails at check_preview_css_ownership.py with NEW SAME-OWNER CSS STACKING FORBIDDEN: {'mixer-fx-rack.css': (76, 8)}. The SonKu branch's fast UI checks omitted this source-owner gate, so the failure emerged only on main push.

Correct fix, not a baseline bypass

  • Prune precisely 72 superseded CSS declarations in .mx-sonku selectors from the existing approved mixer-fx-rack.css owner. Keep the final effective winner per same selector, media context, property and CSS importance, preserving all unique declarations and media variants, and never changing artist PNGs, SVG, page, JS, WIRE or DSP.

  • Deterministic ownership parser equivalent count drops from 76 to 4, below the existing 8 cap. The cap and production CSS owner map remain unchanged.

  • Move the existing cheap scripts/check_preview_css_ownership.py and source owner's unit test into the Fast UI contracts step before Chromium. This prevents a green scoped PR from shipping another same-owner duplication regression into main.

Gate

  • Quick CSS ownership + Fast UI, scoped SonKu native-assembled Chromium and no regression in native picker/ACK/readback. Main full Chromium after merge is a separate release signal; no installer or tag.

  • CSS is source-preserving: only remove overwritten shadowed spans, so the browser-computed winning declarations are unchanged for the same selector/media context.

Source integration PR #670 and original #655 have already been merged to main; this PR repairs the one independent full-preview main guard they exposed.

…-rack owner

Keep the last effective declaration in identical selectors/media contexts; preserve important cascade and existing responsive rules. No stylesheet addition, class change or audio/GUI handler edits. Ownership duplicates drop from 76 to 4 (approved cap 8).
Prevent same-owner / cross-owner CSS layering regressions from reaching main via a green fast job while full Chromium is skipped.
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T13:06:25.710871Z
We couldn’t complete this review. Comment @codex review to try again.
3a61f28 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3a61f28
Status: ✅  Deploy successful!
Preview URL: https://e14d089b.arsonmix.pages.dev
Branch Preview URL: https://fix-sonku-main-css-owner-cle.arsonmix.pages.dev

View logs

@masarray
masarray merged commit 109f8b2 into main Nov 13, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant