Repository navigation
P0 integrate: preserve SonKu M4 SPACE DSP and WIRE Inspector PCM ACK recovery - #650
Merged
Conversation
… after rejected gain/timeout
… last accepted EdgeId snapshot
…eId rejection, focus and stale-route guards
…n and LCD without later snapshot
…ng allocator index 2
…spurious ACK wait
…ny ACK or extra PCM intent
…ng PENDING (#648) fix(native WIRE inspector): resolve rejected gain PENDING from authoritative EdgeId readback
Preserve the exact SonKu SPACE/FDN/GUI + WIRE V66/main history. Replay #648's 12 uniquely anchored hunks across five files onto the new SonKu integration candidate after reproducing the original source byte-for-byte. Keep native PCM single-owner, no public Pages rewrite. Two-parent candidate only; run scoped Chromium, native PCM and UI before integrating. Portable Windows field preview remains separate.
masarray
marked this pull request as ready for review
November 13, 2026 07:40
masarray
merged commit Nov 13, 2026
630c881
into
feat/8d-sonku-m4-reconciled-native-20261113
12 of 13 checks passed
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine/UX reconciliation
Two-parent merge candidate
d2c989fdbb9be7f6468dc22cc83cd5b0d3b818f4merges the latest qualified #606 WIRE Inspector recovery into #649 integrated native SonKu M4 SPACE/FDN candidate. Both parent histories retained, no force-push, one authoritative JUCE/native PCM graph.0bcb695fd7f72a9d39110fd1c146ed8db7ab6b0dcontains SPACE OFF/SQUARE/CHAMBER/LARGE, distance, ambience, preserved spatial core, V66 WIRE and updater.276701e93447602b3e3573bcd815736fb812899eadds exact EdgeId authoritative rollback on rejected/expired gain, no-op gain, stale graph and slider focus retention, Chromium tests..github/workflows/ui-smoke.ymlwas modified by both feature stacks; its WIRE hooks were reconciled without conflict. Public Pages remains unchanged.Acceptance gates
Fast native/UI, native DSP/PCM, actual Chromium SonKu SPACE and WIRE inspector ACK/rejection/no-op. No main merge, public installer, or physical ASIO proof claimed until owner test. Optional #617 portable field-lane evaluated separately.