Repository navigation
fix(native WIRE inspector): resolve rejected gain PENDING from authoritative EdgeId readback - #648
Merged
Conversation
… after rejected gain/timeout
… last accepted EdgeId snapshot
…eId rejection, focus and stale-route guards
…n and LCD without later snapshot
…ng allocator index 2
…spurious ACK wait
…ny ACK or extra PCM intent
masarray
marked this pull request as ready for review
November 13, 2026 07:21
masarray
merged commit Nov 13, 2026
276701e
into
feat/8d-sonku-p0-editor-recovery-20261113
12 of 13 checks passed
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
masarray
added a commit
that referenced
this pull request
Nov 13, 2026
Preserve the exact SonKu SPACE/FDN/GUI + WIRE V66/main history. Replay #648's 12 uniquely anchored hunks across five files onto the new SonKu integration candidate after reproducing the original source byte-for-byte. Keep native PCM single-owner, no public Pages rewrite. Two-parent candidate only; run scoped Chromium, native PCM and UI before integrating. Portable Windows field preview remains separate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Operator-visible bug
An inspector slider showed
PENDING · -12 dBindefinitely after a nativeSET_WIRE_GAINrejection/timeout.onStatuscleared the native gain queue but had no later accepted snapshot to repaint the inspector LCD. A focused slider also risked detachment by genericscope.render()during rollback.Fix
nativeWireGainReadback(next)(exact acceptedEdgeIdand physicalgainLinear, including zero as -∞ floor).rollbackNativeWireInspectoronly to the native assembled/preview/scope. Restore the same slider andUNCHANGED · accepted dBdirectly fromcontroller.state().current; if the exact EdgeId no longer exists, fail closed asSEND UNAVAILABLE.Public Pages
/preview/and DSP/JUCE audio callback unchanged. No new polling, timers, hidden recovery actions or expensive Windows compilation. Stacked onto qualified #606; this PR is not a public release. Existing #606 Windows exact-SHA 43379672554 has PASSED on its original SHA; it does not certify this new change.