Skip to content

fix(native WIRE inspector): resolve rejected gain PENDING from authoritative EdgeId readback - #648

Merged
masarray merged 9 commits into
feat/8d-sonku-p0-editor-recovery-20261113from
fix/native-wire-inspector-rejected-gain-readback-20261113
Nov 13, 2026
Merged

masarray merged 9 commits into
feat/8d-sonku-p0-editor-recovery-20261113from
fix/native-wire-inspector-rejected-gain-readback-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

Operator-visible bug

An inspector slider showed PENDING · -12 dB indefinitely after a native SET_WIRE_GAIN rejection/timeout. onStatus cleared the native gain queue but had no later accepted snapshot to repaint the inspector LCD. A focused slider also risked detachment by generic scope.render() during rollback.

Fix

  • Deduplicate readback conversion into nativeWireGainReadback(next) (exact accepted EdgeId and physical gainLinear, including zero as -∞ floor).
  • Add rollbackNativeWireInspector only to the native assembled /preview/ scope. Restore the same slider and UNCHANGED · accepted dB directly from controller.state().current; if the exact EdgeId no longer exists, fail closed as SEND UNAVAILABLE.
  • On native rejection/timeout/incorrect ACK, clear deferred gains and call the native-only rollback without requiring an impossible new accepted snapshot; don't detach a focused inspector during general rollback.
  • Execute the real compiled method in the Node native protocol regression, including idempotent retry, PRIMARY protection, stale identity guard and explicit no-browser-graph-mutation assertions.

Public Pages /preview/ and DSP/JUCE audio callback unchanged. No new polling, timers, hidden recovery actions or expensive Windows compilation. Stacked onto qualified #606; this PR is not a public release. Existing #606 Windows exact-SHA 43379672554 has PASSED on its original SHA; it does not certify this new change.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 06b1bfe
Status:⚡️  Build in progress...

View logs

@masarray
masarray marked this pull request as ready for review November 13, 2026 07:21
@masarray
masarray merged commit 276701e into feat/8d-sonku-p0-editor-recovery-20261113 Nov 13, 2026
12 of 13 checks passed
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T07:21:21.596721Z
We couldn’t complete this review. Comment @codex review to try again.
06b1bfe Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

masarray added a commit that referenced this pull request Nov 13, 2026
Preserve the exact SonKu SPACE/FDN/GUI + WIRE V66/main history.
Replay #648's 12 uniquely anchored hunks across five files onto the
new SonKu integration candidate after reproducing the original source
byte-for-byte. Keep native PCM single-owner, no public Pages rewrite.

Two-parent candidate only; run scoped Chromium, native PCM and UI before
integrating. Portable Windows field preview remains separate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant