Repository navigation
fix(v61): keep newly plugged selected cable visible and correct encapsulated Chromium proof - #624
Merged
masarray merged 2 commits intoNov 13, 2026
Conversation
…g or route choice
…t incoming cable jacket
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrective follow-up to #622 after main Chromium found the new test incorrectly accessed
wireMotionGeometryas a global. The approved assembled GUI intentionally encloses its graph in a lexical scope; exporting test globals is forbidden. Evaluate the exact checked-in motion function in an isolated Playwright probe with representative plug geometry; continue to observe real DOM path changes/settle in the actual mixer. Also fix real UX: a drag from OUT when a different mixer strip was selected previously could create/mark a new EdgeId without showing the selected wire. After a valid accepted drag, replug or Bus route choice, focus the originating channel and reveal that committed selected cable; canceled/invalid drop still preserves graph and selection. Preserve sprite, fader, native audio bridge, and reduced-motion contract. Scoped quick PR test then one full Chromium on main before Pages.