Skip to content

fix(v61): keep newly plugged selected cable visible and correct encapsulated Chromium proof - #624

Merged
masarray merged 2 commits into
mainfrom
fix/v61-physical-wire-proof-and-drop-focus-20261113
Nov 13, 2026
Merged

masarray merged 2 commits into
mainfrom
fix/v61-physical-wire-proof-and-drop-focus-20261113

Conversation

@masarray

Copy link
Copy Markdown
Owner

Corrective follow-up to #622 after main Chromium found the new test incorrectly accessed wireMotionGeometry as a global. The approved assembled GUI intentionally encloses its graph in a lexical scope; exporting test globals is forbidden. Evaluate the exact checked-in motion function in an isolated Playwright probe with representative plug geometry; continue to observe real DOM path changes/settle in the actual mixer. Also fix real UX: a drag from OUT when a different mixer strip was selected previously could create/mark a new EdgeId without showing the selected wire. After a valid accepted drag, replug or Bus route choice, focus the originating channel and reveal that committed selected cable; canceled/invalid drop still preserves graph and selection. Preserve sprite, fader, native audio bridge, and reduced-motion contract. Scoped quick PR test then one full Chromium on main before Pages.

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T02:43:55.089197Z
We couldn’t complete this review. Comment @codex review to try again.
0d32547 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@masarray
masarray merged commit a123fd9 into main Nov 13, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant