Skip to content

Prevent stale release candidates from omitting newer main improvements - #583

Merged
masarray merged 4 commits into
mainfrom
fix/release-main-ancestry-gate-20261112
Nov 12, 2026
Merged

masarray merged 4 commits into
mainfrom
fix/release-main-ancestry-gate-20261112

Conversation

@masarray

Copy link
Copy Markdown
Owner

Release regression prevention — source completeness gate

Observed failure: Public alpha.12 (db82aff) predates 63 commits / 54 touched paths on current main (62e03cc). Alpha.13 was dispatched before cross-thread reconciliation; its prior source SHA was invalidated on the release branch to prevent publishing a disputed candidate.

Implementation

  • Owner release dispatcher fails closed unless the immutable candidate is ahead of or identical to latest main, with zero commits behind, before allocating a Windows runner.
  • Windows publisher rechecks live main ancestry immediately before calling gh release create, so a long-running build cannot ship a stale source if main advances.
  • Contract tests cover behind, diverged, inconsistent compare, and allowed ahead/identical cases.

Scope and limitations

Only scripts/release_ci_dispatch.mjs, .github/workflows/alpha-preview-publish.yml, and tests/release_ci_dispatch_contract.test.mjs. No native/audio/GUI/installer bytes changed; no full Windows/Chromium build needed for CI-only source.

Not fixed here: pending old draft #512, offline experiment #521, or other unmerged artwork/UI from other threads. Audit against latest main and selectively port approved improvements with tests. Never force-merge diverged drafts or treat this guard as a finished release.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: d60f15a
Status: ✅  Deploy successful!
Preview URL: https://7b2d574c.arsonmix.pages.dev
Branch Preview URL: https://fix-release-main-ancestry-ga.arsonmix.pages.dev

View logs

@masarray
masarray marked this pull request as ready for review November 12, 2026 01:16
@masarray
masarray merged commit 70008b7 into main Nov 12, 2026
1 check passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T01:18:15.207438Z 28823c4 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant