Repository navigation
fix(harmony): P0 clickless warm bypass and continuous Music-key retuning - #502
Merged
masarray merged 5 commits intoNov 9, 2026
Conversation
…ontinuity on tonal changes
masarray
changed the base branch from
integration/asio4all-harmony-d4-compat-20261109
to
main
November 9, 2026 22:14
Owner
Author
|
/arsonmix-ci fat 1ac1a25 |
masarray
changed the base branch from
main
to
integration/asio4all-harmony-d4-compat-20261109
November 9, 2026 22:15
Deploying arsonmix with
|
| Latest commit: |
59056e2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://46941cdf.arsonmix.pages.dev |
| Branch Preview URL: | https://fix-harmony-clickless-music.arsonmix.pages.dev |
…/updater integration without overwrites
…ible switch slope against aligned PCM
…nelId guide across ASIO buffers
…s PCM and multi-rate CPU proof
masarray
changed the base branch from
integration/asio4all-harmony-d4-compat-20261109
to
main
November 9, 2026 22:32
Owner
Author
|
/arsonmix-ci fat 59056e2 |
masarray
changed the base branch from
main
to
integration/asio4all-harmony-d4-compat-20261109
November 9, 2026 22:33
masarray
merged commit Nov 9, 2026
c717be0
into
integration/asio4all-harmony-d4-compat-20261109
6 checks passed
This was referenced Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P0: Harmony clickless bypass + Music guide vocal continuity
Stacked safely atop #499 verification branch (
1dc70dc11185f29b4821a4765f68579b85136f33); DO NOT MERGE #499 or this stacked PR until acceptance and field ASIO qualification. Branch does not mutate #487/#499/main.Source audit (before change)
FxInstance::render()skipped HarmonyprocessBlockwhile fully bypassed. Pitch/grain/Fdn history became stale relative to incoming native PCM. 8 ms envelope alone cannot prime that history on re-enable.HarmonyDsp::setGuideKey()and prepared key/source edits forcibly setvoiced_=false,currentNote_=-1on every effective tonal key change. This interrupts sustained voiced singer despite unchanged input.StereoLatencyDelay, while envelope configured at zero latency. New design retains exact existing latency, with no graph rebuild.Implementation
requiresContinuousBypassProcessing()marks Harmony only. EQ, Compressor and third-party VST3 retain CPU-saving fully bypassed fast path. While Harmony is fully bypassed, PCM still traverses its original DSP instance, but the native owner publishes delay-compensated dry output. Native stereo delay, callback and graph owner unchanged.Regression
NativeHarmonyWarmBypassRackSlotAndLatencyParity: real JUCE processor →FxInstance::render()→DynamicChannelFxLeaseBank; sustained vocal PCM across insert and rack OFF/ON/rapid reverse; verifies wet post-reactivation sample parity against continuously rendering reference and exact 1536-sample bypass dry PDC.NativeHarmonyMultivoicePitchAndRealtimeFinitePCM: regression that sustained vocal stays voiced through manual and Music guide tonal change/fallback, and old pitch does not stick after key change.Still required
Review exact-SHA Linux Harmony and Windows MSVC CTest results, then one exact-SHA Windows FAT/Inno artifact (not older #499 FAT); 48/96k latency/CPU budget incl guide and 3–5 voices; physical ASIO4ALL driver XRUN/ear listening and wet/space stress are not certified by unit tests.
This is a draft qualification PR; no automatic merge.