Skip to content

fix(harmony): P0 clickless warm bypass and continuous Music-key retuning - #502

Merged
masarray merged 5 commits into
integration/asio4all-harmony-d4-compat-20261109from
fix/harmony-clickless-music-continuity-20261110
Nov 9, 2026
Merged

masarray merged 5 commits into
integration/asio4all-harmony-d4-compat-20261109from
fix/harmony-clickless-music-continuity-20261110

Conversation

@masarray

@masarray masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner

P0: Harmony clickless bypass + Music guide vocal continuity

Stacked safely atop #499 verification branch (1dc70dc11185f29b4821a4765f68579b85136f33); DO NOT MERGE #499 or this stacked PR until acceptance and field ASIO qualification. Branch does not mutate #487/#499/main.

Source audit (before change)

  • FxInstance::render() skipped Harmony processBlock while fully bypassed. Pitch/grain/Fdn history became stale relative to incoming native PCM. 8 ms envelope alone cannot prime that history on re-enable.
  • HarmonyDsp::setGuideKey() and prepared key/source edits forcibly set voiced_=false, currentNote_=-1 on every effective tonal key change. This interrupts sustained voiced singer despite unchanged input.
  • Dry latency was already allocated and retained by StereoLatencyDelay, while envelope configured at zero latency. New design retains exact existing latency, with no graph rebuild.

Implementation

  • A control-prepared opt-in requiresContinuousBypassProcessing() marks Harmony only. EQ, Compressor and third-party VST3 retain CPU-saving fully bypassed fast path. While Harmony is fully bypassed, PCM still traverses its original DSP instance, but the native owner publishes delay-compensated dry output. Native stereo delay, callback and graph owner unchanged.
  • Tonal transitions invalidate only the note candidate; hold current voiced envelope, pitch period and grain state while subsequent bounded analyses retune to new scale. Old-key hysteresis is bypassed only during pending tonal revision; silence detection remains authoritative.
  • No new GUI or Show schema, route, latency publication, allocations, mutexes, reset, or extra audio callback.

Regression

  • NativeHarmonyWarmBypassRackSlotAndLatencyParity: real JUCE processor → FxInstance::render() → DynamicChannelFxLeaseBank; sustained vocal PCM across insert and rack OFF/ON/rapid reverse; verifies wet post-reactivation sample parity against continuously rendering reference and exact 1536-sample bypass dry PDC.
  • NativeHarmonyMultivoicePitchAndRealtimeFinitePCM: regression that sustained vocal stays voiced through manual and Music guide tonal change/fallback, and old pitch does not stick after key change.
  • Existing Harmony/UI/Player/ASIO suites remain to be checked.

Still required

Review exact-SHA Linux Harmony and Windows MSVC CTest results, then one exact-SHA Windows FAT/Inno artifact (not older #499 FAT); 48/96k latency/CPU budget incl guide and 3–5 voices; physical ASIO4ALL driver XRUN/ear listening and wet/space stress are not certified by unit tests.

This is a draft qualification PR; no automatic merge.

@masarray
masarray changed the base branch from integration/asio4all-harmony-d4-compat-20261109 to main November 9, 2026 22:14

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 1ac1a25

@masarray
masarray changed the base branch from main to integration/asio4all-harmony-d4-compat-20261109 November 9, 2026 22:15
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Deploying arsonmix with  Cloudflare Pages  Cloudflare Pages

Latest commit: 59056e2
Status: ✅  Deploy successful!
Preview URL: https://46941cdf.arsonmix.pages.dev
Branch Preview URL: https://fix-harmony-clickless-music.arsonmix.pages.dev

View logs

@masarray
masarray changed the base branch from integration/asio4all-harmony-d4-compat-20261109 to main November 9, 2026 22:32

masarray commented Nov 9, 2026

Copy link
Copy Markdown
Owner Author

/arsonmix-ci fat 59056e2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant